chore: Accumulated backports to v4-next#22666
Merged
Conversation
Removed 'should reload keystore' test block that was introduced by a different PR not present on v4-next.
…2529) (#22608) ## Summary Backport of #22529 to v4-next. Adds missing ABI enforcement in the `ArgumentEncoder` that allowed invalid inputs to be silently accepted during simulation via aztec.js: - **Fixed-size arrays**: Oversized/undersized arrays were silently truncated. Now throws if array length doesn't match. - **Strings**: Strings longer than declared length were silently truncated. Now throws if string exceeds max length. - **Top-level argument count**: Extra arguments were silently ignored. Now throws if argument count doesn't match. - **Integer overflow**: Values outside valid range for declared width were accepted without error. Now validates ranges. - **Array type guard**: Non-array values for array parameters now get a clear error. ## Cherry-pick conflict One conflict in `e2e_ha_full.test.ts` — the incoming commit included a "should reload keystore" test block from a different PR not present on v4-next. Resolved by dropping the unrelated test block. ## Test plan - [x] Encoder unit tests pass (34/34) - [x] TypeScript compilation succeeds for changed packages - [x] Verified Noir contract ABIs on v4-next match the updated test arguments ClaudeBox log: https://claudebox.work/s/49d536b7c0544efb?run=1
AztecBot
requested review from
dbanks12,
fcarreiro and
sirasistant
as code owners
The v4-next-staging line moved DataStoreConfig out of @aztec/stdlib/kv-store into kv-store's own ./config subpath (the new './config' export in package.json). Mirror the indexeddb backend's local import so sqlite-opfs compiles on the backport branch. Port-specific: on next/merge-train/fairies this import is still @aztec/stdlib/kv-store.
Backport of #22658 to v4-next. ## Original PR summary Experimental support for SQLite as a backend to kv-store, with the goal of eventually abandoning IndexedDB. ## Conflicts Single conflict in `yarn-project/kv-store/package.json` exports map: - v4-next keeps the `./config` export (still imported by archiver, aztec-node, bot, node-lib, p2p, etc.) whereas that export had been removed on `next`. - Resolved by keeping all three exports: `./sqlite-opfs`, `./stores`, and `./config`. The rest of the cherry-pick (new `sqlite-opfs/` module, wallet entrypoint wiring for `walletDb.store`, yarn.lock) applied cleanly. ## Commits 1. `cherry-pick: ...(with conflicts)` — original squash commit applied with the conflict marker preserved in `package.json`. 2. `fix: resolve cherry-pick conflicts` — keeps the `./config` export alongside the new `./sqlite-opfs` entry. No additional build-adaptation commit was required. ClaudeBox log: https://claudebox.work/s/3c079f039c55d141?run=1
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
Thunkar
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix(abi): add missing ABI validation in argument encoder (backport #22529) (#22608)
fix(pxe): verify private event commitment matches content (#22638)
feat!: kv-store on SQLite-wasm over OPFS (backport #22666)
END_COMMIT_OVERRIDE