fix(aztec-up): Do not leak node_modules/.bin into the PATH

[vezenovm]

Summary

The aztec-up installer adds $HOME/.aztec/current/node_modules/.bin to the user's shell PATH. That directory contains the bin entries of every transitive npm dependency of the Aztec packages, so ~40 third-party bins (jest, tsc, tsserver, semver, uuid, json5, pino, mime, rlp, ...) end up on PATH, silently shadowing user-installed versions.

This PR exposes only the 7 intended @aztec/*-owned bins and drops node_modules/.bin from the PATH line.

Why

Two problems with the current setup:

1. DX / correctness. A developer with jest@29 pinned locally silently runs Aztec's bundled jest@30 when typing jest, producing confusing errors (e.g. the renamed --testPathPattern flag). Same trap for tsc, semver, etc. The user has no way to enumerate what's been shadowed without reading the dep tree.
2. Invocation surface. Install-time trust is unchanged — every package in the graph already runs code via postinstall or when Aztec uses it — but putting transitive bins on PATH adds a new invocation vector: a compromised transitive bin can fire on normal dev activity (jest, tsc) rather than only when Aztec calls it. Notably, that bypasses --ignore-scripts-style defenses and is stealthier than a postinstall payload. Standard package managers (npm install -g, pipx, brew, cargo install) do not expose transitive bins on PATH; they symlink only the package's declared entry points.

Context: https://gist.github.com/AztecBot/fc2f40d50592c468429f922921a271f2 and https://www.notion.so/aztecnetwork/Getting-Started-Token-Tutorial-Walk-Through-348a1f6b0e35806a884edc16742866b9

Changes

• aztec-up/bin/0.0.1/install — new symlink_aztec_bins function, called after install_aztec_packages. Iterates node_modules/.bin/*, keeps only symlinks whose target starts with ../@aztec/, and re-links them into $version_path/bin/ using relative paths (../node_modules/.bin/<name>). No hard-coded list: the set of exposed bins follows whatever @aztec/* packages declare.
• aztec-up/bin/0.0.1/aztec-install — drops $HOME/.aztec/current/node_modules/.bin from the shell-profile PATH export.
• aztec-up/bin/0.0.1/aztec-up — drops node_modules/.bin from aztec-up env output so per-project .aztecrc switching also skips the leak.

Each version's bin/ stays self-contained, so aztec-up use <ver> flips the entire bin set atomically via the current symlink — same mechanism as today.

Verification

Ran the new symlink_aztec_bins function against an existing ~/.aztec/current install, mirrored into a throwaway AZTEC_HOME:

=== Bins exposed in version bin/ ===
aztec aztec-wallet bb bb-cli blob-client noir-codegen txe

=== Symlink resolution ===
aztec         -> .../node_modules/@aztec/aztec/scripts/aztec.sh
aztec-wallet  -> .../node_modules/@aztec/cli-wallet/dest/bin/index.js
bb            -> .../node_modules/@aztec/bb.js/dest/node/bin/index.js
bb-cli        -> .../node_modules/@aztec/bb-prover/dest/bb/index.js
blob-client   -> .../node_modules/@aztec/blob-client/dest/client/bin/index.js
noir-codegen  -> .../node_modules/@aztec/noir-noir_codegen/lib/main.js
txe           -> .../node_modules/@aztec/txe/dest/bin/index.js

=== Transitive bins absent from version bin/ ===
jest tsc tsserver semver uuid json5 pino pino-pretty mime rlp  (all absent)

=== Exec through the chain ===
PATH=$THROWAWAY_BIN:... aztec-wallet --help  →  prints help OK

7 bins exposed vs. 40 before; all resolve; end-to-end execution works.

Confirmed non-regressions

Audited Aztec production CLI code for bare-name shell-outs that could rely on transitive bins being on PATH:

• yarn-project/aztec/scripts/aztec.sh — shells out to anvil, nargo, nc, and itself. anvil/nargo live in current/bin/ (installed by aztec-install), nc is system. Unaffected.
• yarn-project/aztec/src/cli/cmds/compile.ts / profile_gates.ts — resolve bb via findBbBinary() (absolute path from @aztec/bb.js), fall back to bare 'bb' which remains reachable as a new symlink in current/bin/.
• yarn-project/cli/src/cmds/misc/update/npm.ts — intentionally invokes user's system npm/pnpm/yarn. Unaffected.

No other bare-name invocations of transitive bins.

Migration

Fresh installs and aztec-up install <ver> pick up the fix automatically. Existing users still have the old export PATH=…:current/node_modules/.bin:… line in their shell profile; that gets rewritten the next time they run aztec-install (the existing dedup at aztec-install:210 strips old entries). Worth flagging in release notes.

[nchamo]

Great finding and fix!

Bash is not my specialty, but looks pretty good. I left a few comments we can discuss if needed

[nchamo]

LGTM!

[AztecBot]

❌ Failed to cherry-pick to v4-next due to conflicts. (🤖) View backport run.