feat: scrape metrics data#22840
Merged
alexghr merged 1 commit intomerge-train/spartanfrom Apr 29, 2026
Merged
Conversation
Maddiaa0
approved these changes
Apr 29, 2026
spalladino
approved these changes
Apr 29, 2026
Comment on lines
+280
to
298
| this.logCheckpointEvent('publish-failed', `Checkpoint publish failed for slot ${this.targetSlot}`, { | ||
| slot: this.targetSlot, | ||
| checkpointNumber: this.checkpointNumber, | ||
| successfulActions: l1Response?.successfulActions, | ||
| failedActions: l1Response?.failedActions, | ||
| sentActions: l1Response?.sentActions, | ||
| expiredActions: l1Response?.expiredActions, | ||
| reason: 'propose_action_not_successful', | ||
| }); | ||
| this.log.warn(`Checkpoint publish failed for slot ${this.targetSlot}`, { | ||
| slot: this.targetSlot, | ||
| checkpointNumber: this.checkpointNumber, | ||
| successfulActions: l1Response?.successfulActions, | ||
| failedActions: l1Response?.failedActions, | ||
| sentActions: l1Response?.sentActions, | ||
| expiredActions: l1Response?.expiredActions, | ||
| reason: 'propose_action_not_successful', | ||
| }); | ||
| this.eventEmitter.emit('checkpoint-publish-failed', { ...l1Response, slot: this.targetSlot }); |
Contributor
There was a problem hiding this comment.
Do you think we could refactor the log+logevent+emitevent into a helper function that handles all three? This may require unifying the checkpoint-events and the events emitted by the event-emitter, but they are pretty close. No need to do now though, it's just for cleanup.
Contributor
Author
There was a problem hiding this comment.
yes, I'll open the next PR to address this!
alexghr
force-pushed
the
ag/net-bench-scrape
branch
from
23c24be to
d69f67b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.