feat: backport kv-store sqlite encryption (#22759) to v4-next#22927
Merged
mverzilli merged 3 commits intobackport-to-v4-next-stagingfrom May 4, 2026
Merged
Conversation
Combines both sides of the merge in ensurePool(): - Keeps poolDirectory tracking from #22721 (kv-store browser test hangs fix) - Adopts the local 's = sqlite3' alias and sqlite3mc_vfs_create call from #22759 The handleDeleteDb codepath inherited from #22721 (async + ensurePool with remembered poolDirectory) is preserved as-is and is orthogonal to the encryption wrapper, which only kicks in via MC_SAH_POOL_VFS_NAME in handleInit.
AztecBot
added
ci-draft
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
mverzilli
approved these changes
May 4, 2026
The exclude entry was left as the previous package name (@sqlite.org/sqlite-wasm) when worker.ts and package.json were updated to use @aztec/sqlite3mc-wasm. With the new package not excluded, vite's dep optimizer crawls into it during browser test setup and trips an ENOENT race on `.vite/vitest/<hash>/deps` (two concurrent crawls under playwright's server+browser dual-context model), causing src/sqlite-opfs/array.test.ts to fail to import the test file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
AztecBot
added a commit
that referenced
this pull request
May 5, 2026
BEGIN_COMMIT_OVERRIDE docs: add map and state variable docs (#22824) fix: e2e compat should not fail for contracts added after legacy stables (#22900) chore: fix kv-store browser tests hangs (#22721) feat: kv-store sqlite backend with page level encryption (#22759) fix: install node 22 for aztec-cli acceptance test (#22917) feat: backport kv-store sqlite encryption (#22759) to v4-next (#22927) fix(docs): correct llms.txt links for versioned developer docs (#22819) feat(docs): improve discoverability of Aztec.nr API reference docs (#22861) feat(docs): backport improve discoverability of Aztec.nr API reference docs (#22861) to v4-next (#22931) feat(aztec-nr): add call_self stubs for utility functions (#22885) docs: add map and state variable docs (backport #22824) (#22880) refactor: `getPackageVersion` fn cleanup (#22941) fix(ci): skip acceptance test for canary -commit. tags (#22951) fix: closing db, correct stub side effects (#22939) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport of #22759 (
feat: kv-store sqlite backend with page level encryption) tobackport-to-v4-next-staging.The auto-cherry-pick failed on
yarn-project/kv-store/src/sqlite-opfs/worker.ts. The conflict was localized to theensurePoolfunction: the v4-next branch already contains #22721 (kv-store browser test hangs fix), which added apoolDirectory = directory;assignment, while #22759 introduced a locals = sqlite3alias and the sqlite3mc VFS registration call. Both changes are compatible and have been combined.Commit structure
1944712b— original cherry-pick committed as-is with the conflict marker preserved inworker.ts, so reviewers can see exactly what conflicted.0c397e2c— conflict resolution: keepspoolDirectorytracking from chore: fix kv-store browser tests hangs #22721 + the localsalias andsqlite3mc_vfs_createcall from feat: kv-store sqlite backend with page level encryption #22759.No build-fixes commit was needed —
kv-storeandsqlite3mc-wasmboth typecheck clean against the resolved tree.Verification
yarn installsucceeded.tsgo --noEmitis clean for bothkv-storeandsqlite3mc-wasm.Original PR
97c6e48fe9bf269d12fa0640e4e9303f5e7cbae5ClaudeBox log: https://claudebox.work/s/6446d1f92380c25a?run=1
ClaudeBox log: https://claudebox.work/s/6446d1f92380c25a?run=1