chore: backport pxe db schema compatibility test (#22872) to v4-next#22958
Merged
mverzilli merged 6 commits intoMay 6, 2026
Merged
Conversation
Cherry-pick of 63dc224 onto backport-to-v4-next-staging. Conflicts in yarn-project/yarn.lock left as conflict markers; resolved in following commit.
v4-next still requires mkdirp@^1.0.3 (line 21033) while the new jest-file-snapshot dep introduced by #22872 brings mkdirp@^3.0.1. Kept both lockfile entries.
v4-next BlockHash class lacks the BlockHash.ZERO static introduced after the branch cut. Replaced with new BlockHash(Fr.ZERO) which is equivalent.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
mverzilli
approved these changes
May 5, 2026
v4-next's L2TipsStore predates the checkpoint concept and so does not write the 'proposedCheckpoint' key. Removed that entry from the snapshot so the new compatibility test passes against the v4-next storage layout. No source code changes; only the per-store snapshot file.
…872-pxe-db-schema-test
benesjan
added a commit
that referenced
this pull request
May 7, 2026
This PR accumulates backport commits and will be auto-merged overnight. Backports included: - #22977 - chore: backport noirfmt.toml + nargo fmt (#22971) to v4-next - #22958 - chore: backport pxe db schema compatibility test (#22872) to v4-next > Created manually because the auto-cherry-pick step failed for both source PRs (#22971, #22872) due to conflicts; the manual fix-up PRs bypassed the script that normally opens this PR. 🤖 This PR is normally managed automatically by the backport workflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #22872 (
chore: pxe db schema compatibility test) tobackport-to-v4-next-staging.The automatic cherry-pick failed; this PR restores the 3-commit history:
mkdirp@^1.0.3(still required by an existing v4-next dep) andmkdirp@^3.0.1(added viajest-file-snapshot). Both lockfile entries kept.schema_tests.tsreferencedBlockHash.ZERO, a static introduced after the v4-next branch cut. Replaced withnew BlockHash(Fr.ZERO), which is equivalent given v4-next'sBlockHash extends Frdefinition.Verification
yarn installresolves cleanly.yarn workspace @aztec/pxe buildproduces no TypeScript errors in any of the cherry-picked files (pxe.ts,open_pxe_stores.ts,schema_tests.ts,pxe_db_compatibility.test.ts,store_spy.ts,kv_store_snapshot.ts, the snapshot JSON files, andkv-store/src/interfaces/index.ts). Remaining pre-existing build errors on v4-next come from un-builtnoir-test-contracts.js,bb.js, andprotocol-contractsartifacts — not from this backport.Original PR: #22872
ClaudeBox log: https://claudebox.work/s/0ba4053229d8855a?run=1