Skip to content

chore: backport pxe db schema compatibility test (#22872) to v4-next#22958

Merged
mverzilli merged 6 commits into
backport-to-v4-next-stagingfrom
claudebox/backport-22872-pxe-db-schema-test
May 6, 2026
Merged

chore: backport pxe db schema compatibility test (#22872) to v4-next#22958
mverzilli merged 6 commits into
backport-to-v4-next-stagingfrom
claudebox/backport-22872-pxe-db-schema-test

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

@AztecBot AztecBot commented May 5, 2026

Backport of #22872 (chore: pxe db schema compatibility test) to backport-to-v4-next-staging.

The automatic cherry-pick failed; this PR restores the 3-commit history:

  1. Cherry-pick (with conflict markers) — records the original cherry-pick attempt. yarn.lock left with conflict markers.
  2. Conflict resolution — yarn.lock had a conflict between mkdirp@^1.0.3 (still required by an existing v4-next dep) and mkdirp@^3.0.1 (added via jest-file-snapshot). Both lockfile entries kept.
  3. Build fixschema_tests.ts referenced BlockHash.ZERO, a static introduced after the v4-next branch cut. Replaced with new BlockHash(Fr.ZERO), which is equivalent given v4-next's BlockHash extends Fr definition.

Verification

  • yarn install resolves cleanly.
  • yarn workspace @aztec/pxe build produces no TypeScript errors in any of the cherry-picked files (pxe.ts, open_pxe_stores.ts, schema_tests.ts, pxe_db_compatibility.test.ts, store_spy.ts, kv_store_snapshot.ts, the snapshot JSON files, and kv-store/src/interfaces/index.ts). Remaining pre-existing build errors on v4-next come from un-built noir-test-contracts.js, bb.js, and protocol-contracts artifacts — not from this backport.

Original PR: #22872

ClaudeBox log: https://claudebox.work/s/0ba4053229d8855a?run=1

mverzilli and others added 3 commits May 5, 2026 16:22
Cherry-pick of 63dc224 onto backport-to-v4-next-staging. Conflicts in yarn-project/yarn.lock left as conflict markers; resolved in following commit.
v4-next still requires mkdirp@^1.0.3 (line 21033) while the new jest-file-snapshot dep introduced by #22872 brings mkdirp@^3.0.1. Kept both lockfile entries.
v4-next BlockHash class lacks the BlockHash.ZERO static introduced after the branch cut. Replaced with new BlockHash(Fr.ZERO) which is equivalent.
@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels May 5, 2026
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 5, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​jest-file-snapshot@​0.7.0971009576100

View full report

AztecBot and others added 3 commits May 6, 2026 06:44
v4-next's L2TipsStore predates the checkpoint concept and so does not write the 'proposedCheckpoint' key. Removed that entry from the snapshot so the new compatibility test passes against the v4-next storage layout. No source code changes; only the per-store snapshot file.
@mverzilli mverzilli merged commit b0496cf into backport-to-v4-next-staging May 6, 2026
11 checks passed
@mverzilli mverzilli deleted the claudebox/backport-22872-pxe-db-schema-test branch May 6, 2026 07:33
benesjan added a commit that referenced this pull request May 7, 2026
This PR accumulates backport commits and will be auto-merged overnight.

Backports included:
- #22977 - chore: backport noirfmt.toml + nargo fmt (#22971) to v4-next
- #22958 - chore: backport pxe db schema compatibility test (#22872) to
v4-next

> Created manually because the auto-cherry-pick step failed for both
source PRs (#22971, #22872) due to conflicts; the manual fix-up PRs
bypassed the script that normally opens this PR.

🤖 This PR is normally managed automatically by the backport workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants