chore: translator fixes#22983
Merged
Merged
Conversation
ludamad
reviewed
May 6, 2026
| // contribute zero and are simply not emitted. | ||
| std::array<FFType, NUM_CONCATENATED_POLYS> result; | ||
| size_t group_idx = 0; | ||
| #define ACCUMULATE_REF(name) \ |
Collaborator
There was a problem hiding this comment.
I don't like this honestly. I'd prefer verbose + a foolproof test or using constexpr templates
Collaborator
|
Not a big fan of the macros here. I'd really just prefer a standalone typescript file (the best scripting format we have available, IMO, node can just run it these days with no compilation) to generate the code, and to checkin the generated code |
ludamad
requested changes
May 6, 2026
ludamad
approved these changes
May 6, 2026
Collaborator
ludamad
left a comment
ludamad
left a comment
There was a problem hiding this comment.
approving for now after discussion about delaying longer term plans of code gen
federicobarbacovi
approved these changes
May 11, 2026
Contributor
federicobarbacovi
left a comment
federicobarbacovi
left a comment
There was a problem hiding this comment.
Thanks for this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.