feat(pxe,nr): flesh out account stubs and don't exclude syncing for overrides#23054
Merged
dbanks12 merged 1 commit intomerge-train/fairiesfrom May 8, 2026
Merged
feat(pxe,nr): flesh out account stubs and don't exclude syncing for overrides#23054dbanks12 merged 1 commit intomerge-train/fairiesfrom
dbanks12 merged 1 commit intomerge-train/fairiesfrom
Conversation
This was referenced May 7, 2026
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dbanks12
force-pushed
the
db/private-sim-contract-overrides
branch
from
9aa157b to
713e7c5
Compare
dbanks12
force-pushed
the
db/flesh-out-stubs
branch
from
fd5d974 to
49d9722
Compare
dbanks12
force-pushed
the
db/private-sim-contract-overrides
branch
from
713e7c5 to
b5280d2
Compare
dbanks12
force-pushed
the
db/flesh-out-stubs
branch
2 times, most recently
from
4f39410 to
392cab1
Compare
dbanks12
force-pushed
the
db/private-sim-contract-overrides
branch
from
b5280d2 to
14c427f
Compare
dbanks12
force-pushed
the
db/flesh-out-stubs
branch
from
392cab1 to
7a70d95
Compare
dbanks12
force-pushed
the
db/private-sim-contract-overrides
branch
from
14c427f to
ccd607a
Compare
dbanks12
force-pushed
the
db/flesh-out-stubs
branch
from
7a70d95 to
bf17e47
Compare
dbanks12
force-pushed
the
db/private-sim-contract-overrides
branch
from
ccd607a to
f8f2a94
Compare
dbanks12
force-pushed
the
db/flesh-out-stubs
branch
from
bf17e47 to
c8aa93d
Compare
dbanks12
changed the title
Base automatically changed from
db/private-sim-contract-overrides
to
merge-train/fairies
May 8, 2026 01:27
Thunkar
approved these changes
May 8, 2026
Mirrors the real-account note storage (signing_public_key) on the simulated Schnorr/ECDSA account stubs and removes the manual sync_state() override so the #[aztec] macro generates a sync_state matching the real contract's selector. With matching note storage, the macro-generated _compute_note_hash can decode the real account's signing_public_key note during simulation sync. Removes the PXE setExcludedFromSync plumbing that previously skipped overridden contracts from sync. Required for fastForwardContractUpdate's private-call simulation to discover notes through the override.
dbanks12
force-pushed
the
db/flesh-out-stubs
branch
from
c8aa93d to
c5f9cb8
Compare
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 10, 2026
BEGIN_COMMIT_OVERRIDE fix: include sqlite binary in its npm package (#23039) fix: add sendMessagesAs to wallet api schemas (#23041) refactor(pxe): deduplicate tx hash lookups in MessageContextService (#23075) refactor(pxe): batch tagged private log queries across all secrets (#23048) refactor(pxe): batch log RPC calls in LogService.fetchLogsByTag (#23088) feat(pxe,nr): flesh out account stubs and don't exclude syncing for overrides (#23054) feat: deploy method refactor 2 (#23033) feat: fastForwardContractUpdate cheatcode for simulating contract updates (#22905) refactor(stdlib): consolidate find-function-by-selector helpers (#23008) feat(ci): Snapshots for aztec-nr contract compilation failures and nargo expand (#23061) chore: kv store test fully on vitest (#23096) refactor(pxe): skip redundant getBlock RPC when querying at anchor block (#23100) chore(playground): bump main chunk size limit 1750 → 1800 KB (#23107) feat(txe): allow authorizing cross-contract utility calls in nr tests (#23064) chore: bench public fns with emit repro (#23105) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flesh out account stubs so that syncing actually works for them, and then remove their exclusion