Skip to content

chore: backport noir sync PRs to backport-to-v4-next-staging#23148

Merged
benesjan merged 9 commits into
backport-to-v4-next-stagingfrom
backport-noir-syncs-to-v4-next-staging
May 11, 2026
Merged

chore: backport noir sync PRs to backport-to-v4-next-staging#23148
benesjan merged 9 commits into
backport-to-v4-next-stagingfrom
backport-noir-syncs-to-v4-next-staging

Conversation

@benesjan
Copy link
Copy Markdown
Contributor

@benesjan benesjan commented May 11, 2026

Summary

Backports the 8 noir sync PRs merged to next after #22393 (which was already cherry-picked onto backport-to-v4-next-staging).

Cherry-picked in chronological order:

Final noir/noir-repo submodule pointer matches next: 1d9727a6e0a9df75a71bb9c87daacbe30659ba09.

Label ci-no-squash is set to preserve the 8 individual commits.

Contract snapshot updates

A follow-up commit regenerates noir-projects/contract-snapshots snapshots that drifted due to the new noir version. All 60 snapshot tests pass locally after the update. The drift is purely from noir-side changes — no semantic change in our code:

  • compile_failure/authorization_selector_collision: noir removed a redundant check_parent_traits_are_implemented: missing trait ID error, so the total error count went from 6 to 5.
  • 6 × expand/* snapshots (amm_contract, avm_gadgets_test_contract, avm_test_contract, public_fns_with_emit_repro_contract, storage_proof_test_contract, token_contract): nargo expand now prints the full unconstrained fn(AztecAddress, u64, u64, BoundedVec<Field, 11>, MessageContext, AztecAddress) type instead of the CustomMessageHandler<()> alias.
  • expand/token_contract, expand/amm_contract, expand/avm_test_contract: nargo expand emits functions in a new deterministic order (e.g. constructor / _reduce_total_supply / _recurse_subtract_balance / private_get_symbol were moved within their impl blocks; add_args_return likewise on the AVM contract; swap_exact_tokens_for_tokens / swap_tokens_for_exact_tokens swapped order on AMM).

Test plan

  • CI on backport-to-v4-next-staging flow passes

vezenovm and others added 8 commits May 11, 2026 13:09
Automated update of Noir submodule to latest nightly.

**Current**: unknown
**New**: nightly-2026-04-15

[View changes in
noir-lang/noir](noir-lang/noir@842974f...nightly-2026-04-15)
Automated update of Noir submodule to latest nightly.

**Current**: unknown
**New**: nightly-2026-04-16

[View changes in
noir-lang/noir](noir-lang/noir@04a373e...nightly-2026-04-16)
Automated update of Noir submodule to latest nightly.

**Current**: unknown
**New**: nightly-2026-04-17

[View changes in
noir-lang/noir](noir-lang/noir@b3b0faa...nightly-2026-04-17)
Automated update of Noir submodule to latest nightly.

**Current**: unknown
**New**: nightly-2026-04-23

[View changes in
noir-lang/noir](noir-lang/noir@ad02a20...nightly-2026-04-23)
Automated update of Noir submodule to latest nightly.

**Current**: unknown
**New**: nightly-2026-04-28

[View changes in
noir-lang/noir](noir-lang/noir@f39ac4f...nightly-2026-04-28)
Automated update of Noir submodule to latest nightly.

**Current**: unknown
**New**: nightly-2026-05-01

[View changes in
noir-lang/noir](noir-lang/noir@5f68596...nightly-2026-05-01)
Automated update of Noir submodule to latest nightly.

**Current**: unknown
**New**: nightly-2026-05-05

[View changes in
noir-lang/noir](noir-lang/noir@20391fd...nightly-2026-05-05)
Automated update of Noir submodule to latest nightly.

**Current**: unknown
**New**: nightly-2026-05-11

[View changes in
noir-lang/noir](noir-lang/noir@d52888d...nightly-2026-05-11)
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 11, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedcargo/​libc@​0.2.184 ⏵ 0.2.1808010093100100
Updatednpm/​@​aztec/​noir-noir_js@​1.0.0-beta.19 ⏵ 1.0.0-beta.21100100100100100

View full report

Accepts snapshot diffs after backporting noir sync PRs #22572-#23023:

- CustomMessageHandler<()> type alias now expands to its full fn type in nargo expand output (cosmetic)

- nargo expand emits functions in a new deterministic order (token, amm, avm_test_contract)

- authorization_selector_collision: one redundant 'missing trait ID' error removed by noir (6 -> 5 errors)
@benesjan benesjan merged commit 5f63954 into backport-to-v4-next-staging May 11, 2026
17 of 18 checks passed
@benesjan benesjan deleted the backport-noir-syncs-to-v4-next-staging branch May 11, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants