chore: update noir submodule with serialization changes#23155
Draft
TomAFrench wants to merge 11 commits into
Draft
chore: update noir submodule with serialization changes#23155TomAFrench wants to merge 11 commits into
TomAFrench wants to merge 11 commits into
Conversation
ECAdd no longer takes is_infinite operands. Update the transpiler, inline ECADD handler, and MSM procedure to use the new (x, y) point layout with (0, 0) as the point at infinity.
Regenerate acir.hpp from noir's autogen and propagate the resulting shape changes through the dsl: - ECAdd / MSM no longer carry is_infinite; (0, 0) is now the point at infinity throughout EcAdd, MultiScalarMul, and to_grumpkin_point. - MemOp switches from three Expressions (operation, index, value) to (read: bool, index: Witness, value: Witness). - Circuit drops current_witness_index. Tests that exercised the externally-supplied infinity flag have been dropped since the flag no longer exists; (0,0)-roundtrip cases are kept.
# Conflicts: # noir/noir-repo
Acir::MemOp no longer accepts Expression-shaped index/value after the serialization change; mem_op_to_acir_mem_op now asserts both are witnesses. The ROM/RAM/CallData test configs that exercised constant ops (perform_constant_ops = true) round-trip through that helper and trip the assertion, so drop those configs together with the unused add_constant_ops helper and template flag.
EmbeddedCurveAdd dropped is_infinite in 4992cb1, so each MSM point is now two field elements and the output is (x, y). The two size assertions were missed in that change; update them to match.
Resolve conflicts in dsl/acir_format/ around the MemOp shape change: - block_constraint.test.cpp: keep both the new MemOp encoding tests (updated to use uint32_t index/value) and the broader RAMTestConfigs from next. - acir_to_constraint_buf.cpp: drop the now-obsolete Acir::Expression decoders; with the new Acir::MemOp shape, index/value are witness indices and read is a bool. - test_class.hpp: simplify mem_op_to_acir_mem_op to pass uint32_t index/value through as Acir::Witness. Also fix MultiScalarMulTestsNoneConstant/0.GenerateVKFromConstraints: EmbeddedCurveAdd/MSM dropped is_infinite, so each point is now (x, y). The test was still appending a third element to the points vector, reading past the end of point_indices and feeding garbage witness indices into the constraint system.
EmbeddedCurveAdd/MSM dropped is_infinite from points (4992cb1). The constraint now uses 6 fewer gates for MSM and 8 fewer for EcAdd, so update the opcode-gate-count expectations to match.
This was referenced May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
noir/noir-reposubmodule from1d9727a6e0tof1a4575ada.Notable upstream changes:
chore!: change Circuit serialization format (remove current_witness_index)chore!: change MemOp serialization formatchore!: remove is_infinite from EmbeddedCurvePointfix(elaborator): simplify re-borrowing expressions(chore(sandbox): expose anvil port #12599)fix: correct error span for unused numeric type alias(chore(p2p): add tx queue to prevent ddos attacks #12603)Test plan