chore: backport kv-store vitest migration (#23096) to v4-next#23185
Merged
mverzilli merged 2 commits intoMay 12, 2026
Merged
Conversation
Deprecates mocha as a test runner for kv-store (we currently half part in mocha part in vitest). The seemingly off-topic change in stdlib stems from L2TipsStore tests being generated from there but consumed from kv-store. It's a bit of a strange pattern that maybe we should reconsider. Cherry-picked from 4b5178a — conflicts preserved with markers (see next commit for resolution).
- yarn-project/kv-store/src/lmdb-v2/store.test.ts: drop 'Map size validation' describe block — added by PR #22400 which is not on v4-next. - yarn-project/kv-store/src/lmdb/store.test.ts: keep deleted on v4-next (file does not exist there; was re-added by PR #21539 which is not on v4-next). - yarn-project/yarn.lock: regenerated via 'yarn install' to align with package.json changes.
AztecBot
added
ci-draft
mverzilli
approved these changes
May 12, 2026
mverzilli
merged commit c65e17c
into
backport-to-v4-next-staging
22 of 32 checks passed
AztecBot
added a commit
that referenced
this pull request
May 13, 2026
BEGIN_COMMIT_OVERRIDE chore: kv store test fully on vitest (#23096) chore: backport kv-store vitest migration (#23096) to v4-next (#23185) test: add noir tests for get_note_hash_membership_witness (#23190) fix(aztec-up): explicit exit in CLI acceptance test harness (#23200) refactor(pxe): batch nullifier sync across scopes (#23129) refactor(pxe): backport batch nullifier sync across scopes (#23129) to v4-next (#23208) fix(ci): revert ci-compat-e2e to AWS access keys (#23211) test: drop event_logs from compat matrix and loosen avm_simulator assertion regex (#23193) fix(aztec-up): install manifest-pinned Node version instead of LTS (#23201) fix(ci): move CLI acceptance test timeout from job to step (#23205) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backports #23096 — chore: kv store test fully on vitest — to
v4-nextviabackport-to-v4-next-staging.Commits
chore: kv store test fully on vitest (#23096)— original cherry-pick attempt with conflict markers preserved, so reviewers can see what conflicted.fix: resolve cherry-pick conflicts— minimal, surgical resolution.Conflict resolution
The automatic cherry-pick produced three conflicts:
yarn-project/kv-store/src/lmdb-v2/store.test.ts(content/content) — theMap size validationdescribe block was added tonextby PR #22400 (fix: use Int64Value instead of Uint32Value for 64-bit map sizes), which is not onv4-next. PR chore: kv store test fully on vitest #23096 was migrating that block from chai to vitest. Since the block does not exist onv4-next, the migration target is absent, so the block was dropped.yarn-project/kv-store/src/lmdb/store.test.ts(deleted/modified) — this file was deleted onv4-nextby PR #12927 (feat: Node snapshot sync) and re-added onnextby PR #21539 (fix(kv-store): make LMDB clear and drop operations atomic across sub-databases). fix(kv-store): make LMDB clear and drop operations atomic across sub-databases #21539 is not onv4-next, so the file should remain deleted; the migration of its tests is irrelevant.yarn-project/yarn.lock— version drift between branches (just-extend,jwa,minimatch). Regenerated viayarn installto align with the newpackage.jsonmanifests.Build verification
Local
yarn buildrequires pre-built@aztec/bb.jsand@aztec/l1-artifacts(downloaded during full bootstrap), which is not feasible inside this container. The cherry-pick changes touch only test files plus dev-dependencies;yarn installsucceeded cleanly. Relying on CI to validate the full TypeScript build and tests.ClaudeBox log: https://claudebox.work/s/9f9aee0884bd626d?run=2