test(bb): avoid vacuous iterations in BatchMultiScalarMul (merge-train flake refresh)#23227
Draft
AztecBot wants to merge 1 commit into
Draft
test(bb): avoid vacuous iterations in BatchMultiScalarMul (merge-train flake refresh)#23227AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The merge-train PR #23137 (head
d016756552) failed its merge-queue CI run on a TXE/AVM flake unrelated to anything on the train —noir-contracts orderbook_contract test::test::create_order_zero_ask_amountgotTimeout waiting for TypeScript callback for contract classfrom the AVM NAPI callback after 60s. The PR that was just merged into the train (#23226) only touches one barretenberg MSM test file, so it cannot have caused the failure. Per.claude/skills/merge-trains/SKILL.mdoption 1, landing a small PR ontomerge-train/barretenbergrefreshes the HEAD SHA so auto-merge can re-engage on #23137 (it won't re-enable after afailureconclusion).Full analysis (failed run, log keys, why we can't reproduce
./bootstrap.sh cilocally): https://gist.github.com/AztecBot/24eb9bfac0fb6e29bdfcf031a7f50a63What
Tiny test-quality follow-up to #23226 in the same file.
test_batch_multi_scalar_mulwas computingnum_msms = rand_u8 % kMaxBatchMSMsandnum_pts = rand_u16 % kMaxBatchPointsPerMSM, both of which can be 0 — making that iteration (or the whole test invocation) vacuous. Switched to1 + (rand % (kMax - 1))so every run exercises at least one MSM with at least one point. Max bound is unchanged (stillkMax - 1), so the existingstatic_assert(kMaxBatchMSMs * kMaxBatchPointsPerMSM < num_points, ...)and runtimeASSERT_LTcontinue to hold.How to land
This needs the
ci-skiplabel and a force-merge via "Merge without waiting for requirements to be met" —claudeboxcan't apply labels itself. The point of this PR is to refresh the merge-train SHA, not to validate the test-quality tweak via CI.Verification
6/6 pass on BN254 and Grumpkin (
BatchMultiScalarMul,BatchMultiScalarMulSparse,ScalarsUnchangedAfterBatchMultiScalarMul).ClaudeBox log: https://claudebox.work/s/c5fe8d2727b143f9?run=1