Skip to content

feat: msgpack-tagged format#23247

Merged
aakoshh merged 1 commit into
nextfrom
af/12554-msgpack-tagged
Jun 5, 2026
Merged

feat: msgpack-tagged format#23247
aakoshh merged 1 commit into
nextfrom
af/12554-msgpack-tagged

Conversation

@aakoshh

@aakoshh aakoshh commented May 13, 2026

Copy link
Copy Markdown
Contributor

Barretenberg side of noir-lang/noir#12554

  • adds support for the msgpack-tagged format
  • allows all msgpack* formats

Tested similarly to #12841 with a nargo compiled from noir-lang/noir#12652

The bytecode size gains were measured in noir-lang/noir#12635

@aakoshh aakoshh force-pushed the af/12554-msgpack-tagged branch from 761c04a to 6b91661 Compare May 13, 2026 20:11
@aakoshh aakoshh marked this pull request as ready for review May 13, 2026 20:13
@aakoshh aakoshh requested review from TomAFrench, fcarreiro, federicobarbacovi and ludamad and removed request for fcarreiro May 13, 2026 20:13

@federicobarbacovi federicobarbacovi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@aakoshh aakoshh force-pushed the af/12554-msgpack-tagged branch from 2780590 to abc6e33 Compare June 5, 2026 11:52
@aakoshh aakoshh added this pull request to the merge queue Jun 5, 2026
@ludamad

ludamad commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

Thanks, have you fuzzed this parser?

Merged via the queue into next with commit 9df0d05 Jun 5, 2026
20 checks passed
@aakoshh aakoshh deleted the af/12554-msgpack-tagged branch June 5, 2026 13:55
@aakoshh

aakoshh commented Jun 6, 2026

Copy link
Copy Markdown
Contributor Author

@federicobarbacovi we fuzzed the Rust part, but not the C++ yet, I only had a brief manual test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants