fix(aztec-up): fall back to no timeout when /usr/bin/timeout absent (macOS)#23310
Merged
Merged
Conversation
4a95f44 to
11e1b78
Compare
vezenovm
reviewed
May 15, 2026
vezenovm
approved these changes
May 15, 2026
rangozd
pushed a commit
to rangozd/aztec-packages
that referenced
this pull request
May 16, 2026
BEGIN_COMMIT_OVERRIDE fix(aztec-up): fall back to no timeout when /usr/bin/timeout absent (macOS) (AztecProtocol#23310) chore: reduce compat e2e timeout (AztecProtocol#23318) feat(aztec-nr): V2 handshake registry for non interactive constrained delivery (AztecProtocol#23278) chore(aztec-nr): Public internal/utility methods self constructor (AztecProtocol#23115) END_COMMIT_OVERRIDE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The aztec-up installer wraps
foundryupin atimeoutshell function. The previous implementation only worked on Linux: it gated the call onCI=trueand invoked/usr/bin/timeoutdirectly./usr/bin/timeoutships with GNU coreutils and is absent on stock macOS, so on a macOS GitHub Actions runner (CI=trueis auto-set) the installer aborted ininstall_foundrywith:Fix
Rework the
timeoutfunction so it picks a working backend at runtime. The CI gate is preserved — non-CI runs continue to execute unguarded, matching prior behavior:/usr/bin/timeoutwhen present (Linux via coreutils).perl -e 'alarm ...; exec ...'when/usr/bin/timeoutis missing. Perl ships preinstalled on macOS and GitHub's Ubuntu runners, so the guard remains effective there.Verified the three branches in containers (coreutils path, perl path, neither): timeouts fire at the expected duration, exit codes propagate, and the unguarded branch passes through completion.