Skip to content

fix: avoid npm uplink for aztec-up local publishes#23396

Merged
alexghr merged 2 commits into
merge-train/spartanfrom
ag/fix-aztec-up-local-npm-publish
May 19, 2026
Merged

fix: avoid npm uplink for aztec-up local publishes#23396
alexghr merged 2 commits into
merge-train/spartanfrom
ag/fix-aztec-up-local-npm-publish

Conversation

@alexghr
Copy link
Copy Markdown
Contributor

@alexghr alexghr commented May 19, 2026

Summary:

  • Keep @aztec/* local in the aztec-up Verdaccio build registry so publishing Aztec packages does not depend on npmjs uplink health.
  • Continue proxying other scoped and unscoped packages to npmjs for dependency cache priming.

CI failure investigated:

  • PR feat: merge-train/spartan #23344 failed ./bootstrap.sh, ci/x-full-no-test-cache, and npm publish contexts.
  • Downloaded logs with yarn ci dlog: f5535395aab63996, 1779189592567743, and 51444ba79e6c8a4a.
  • The direct npm publish log failed with E503: one of the uplinks is down, refuse to publish, while publishing @aztec/protocol-contracts to local Verdaccio.

Validation:

  • bash -n aztec-up/bootstrap.sh

@alexghr alexghr requested a review from charlielye as a code owner May 19, 2026 13:02
@alexghr alexghr enabled auto-merge (squash) May 19, 2026 13:06
@spalladino spalladino added the claudebox Owned by claudebox. it can push to this PR. label May 19, 2026
@spalladino
Copy link
Copy Markdown
Contributor

/claudebox package @aztec/viem is not published locally, we need to allow it to be proxied. Add it as an exception to the @aztec/* wildcard at the top. Also scan for other packages as well that are not published locally. Also bring in the publish: allow_offline setting from branch cb/dd69e1f0bb2f if it makes sense.

@AztecBot
Copy link
Copy Markdown
Collaborator

AztecBot commented May 19, 2026

Run #1 — Session completed (10m)
Live status

Added @aztec/viem as an npm exception in docs/examples/ts/lib.sh (only @aztec/* package not local — others use link: prefix already) and brought in publish: allow_offline: true from cb/dd69e1f0bb2f. Full analysis: https://gist.github.com/AztecBot/fcbb5ff446d16891e758bcba38632ef3

Two follow-up tweaks on top of the @aztec/* local block to fully avoid
the npmjs uplink E503 failure:

- publish.allow_offline: true (from cb/dd69e1f0bb2f) lets verdaccio
  accept publishes when the uplink existence check fails. This is the
  direct fix for the 503 seen on PR #23344.
- @aztec/viem is a third-party fork on npm, not built locally. Match it
  before @aztec/* so it can still be proxied from npmjs.
@alexghr alexghr disabled auto-merge May 19, 2026 15:47
@alexghr alexghr enabled auto-merge (squash) May 19, 2026 15:47
@alexghr alexghr merged commit 16ebffe into merge-train/spartan May 19, 2026
14 checks passed
@alexghr alexghr deleted the ag/fix-aztec-up-local-npm-publish branch May 19, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants