test(e2e): ignore benign 'Insufficient valid txs' block-build-failed in epochs tests#23424
Merged
spalladino merged 1 commit intoMay 20, 2026
Merged
Conversation
spalladino
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
e2e_epochs/epochs_mbps "builds multiple blocks per slot with L2 to L1 messages"flake that hard-failed themerge-train/spartanCI in run 26150606646 (log 1779264300727828).Root cause
The block builder emits
block-build-failedwith reason"Insufficient valid txs"whenever it attempts to build a block but the mempool happens to be empty at that exact moment (sequencer-clientcheckpoint_proposal_job.ts). In the failing run, sequencer-2 successfully built a 6-block checkpoint at slot 14, then tried to build a 7th block within the same slot after all 5 L2→L1 test txs had already been mined — the empty mempool produced the benign event.EpochsTestContext.watchSequencerEventsalready explicitly excludesblock-tx-count-check-failedfor exactly this reason (see existing comment on L512).block-build-failedwith reason"Insufficient valid txs"is the same "not enough txs to build a block" case, just detected after the builder started processing rather than during the pre-check. The retry hit the same race, producing a hard CI failure.Fix
In
watchSequencerEvents, dropblock-build-failedevents whose reason is exactly"Insufficient valid txs". The other failure path incheckpoint_proposal_job.ts(thecatchblock) emitsblock-build-failedwith the exception's message, so genuine block-builder errors still surface.ClaudeBox log: https://claudebox.work/s/ed927253171f52af?run=1