test(ci): skip e2e_ha_full entirely on merge-train/spartan#23542
Merged
Conversation
The HA full suite has been unstable under HA pipelining with multiple distinct failure modes (per-test assertion failures, afterAll teardown hook timeouts, peer races on checkpoint proposals). Flake-only flagging was not enough — ci3 retries once and the suite fails both attempts, so PRs (e.g. #23344) keep getting dequeued. Collapse the four overlapping e2e_ha_full entries into a single skip: true entry until the HA pipelining work stabilises.
PhilWindle
approved these changes
May 24, 2026
This was referenced May 24, 2026
PhilWindle
pushed a commit
that referenced
this pull request
May 24, 2026
…rain/spartan (#23544) ## Summary PR #23344 was dequeued again at https://github.com/AztecProtocol/aztec-packages/actions/runs/26370196367. The flake-flag added in #23528 (`error_regex: "Tx dropped by P2P node"`) wasn't enough — ci3 retries once and the multi-validator web3signer suite has now been seen failing in a second pipelining-related mode that the regex doesn't match. Both observed modes hit the same `should build blocks & attest with multiple validator keys` case: - `Tx dropped by P2P node` at `Promise.all` index 0 (the original mode, ci.aztec-labs.com/9a5fa90aa18f62e7). - Proposer misses the slot's 5-attestation deadline → `AttestationTimeoutError: Timeout collecting attestations for slot 29: 0/5`, followed by `Simulation error: Block 0x… not found in the node. This might indicate a reorg has occurred.` (ci.aztec-labs.com/b91d3218b5e88ae4). Following the same pattern as #23542 for `e2e_ha_full`: collapse the existing error_regex entry into a single `skip: true` so the suite is outright skipped on `merge-train/spartan` until proposer pipelining stabilises. ## Notes - Targets `merge-train/spartan` per yarn-project default base. - Owner kept as @PaLLa (current owner of the entry from #23528). Requested in Slack by @PhilWindle. --- *Created by [claudebox](https://claudebox.work/v2/sessions/dc484e7becc621c7) · group: `slackbot`*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #23344 was dequeued again at https://github.com/AztecProtocol/aztec-packages/actions/runs/26364977301. The flake-flag added in #23541 wasn't enough — ci3 retries once and the HA full suite fails both attempts. Multiple distinct failure modes have been hit recently:
✕ should coordinate governance voting across HA nodes✕ should distribute work across multiple HA nodesExceeded timeout of [0-9]+ ms for a hookTimed out waiting for block with archive matching checkpoint proposal,already proposed block for slot N index 0)This change collapses the four overlapping
e2e_ha_fullentries in.test_patterns.ymlinto a singleskip: trueentry so the suite is outright skipped onmerge-train/spartanuntil HA pipelining stabilises.Notes
merge-train/spartanper yarn-project default base.src/e2e_slashing/attested_invalid_proposal.test.tsentry left untouched.Requested in Slack by @PhilWindle.
Created by claudebox · group:
slackbot