Skip to content

test(e2e): wait for checkpoint before sentinel assertions in e2e_p2p_multiple_validators_sentinel#23573

Merged
spalladino merged 1 commit into
merge-train/spartanfrom
spl/fix-sentinel-warmup
May 27, 2026
Merged

test(e2e): wait for checkpoint before sentinel assertions in e2e_p2p_multiple_validators_sentinel#23573
spalladino merged 1 commit into
merge-train/spartanfrom
spl/fix-sentinel-warmup

Conversation

@spalladino
Copy link
Copy Markdown
Contributor

Summary

  • Stabilizes the multiple-validator sentinel e2e by waiting for a post-warmup checkpoint before recording the assertion window.
  • Reuses the same warm-up helper in the second test so isolated runs avoid the same fresh-network startup noise before stopping a validator.

Failed run

Failed CI run: http://ci.aztec-labs.com/07fb31bc0706159f

The failing test was e2e_p2p_multiple_validators_sentinel > collects attestations for all validators on a node. The test expected no attestation-missed entries, but the assertion window started while the network was still in the first pipelined slots after startup. In the failed run, slot 8 was built on a pending, not-yet-checkpointed parent, so some remote validators could not validate/attest in time and the sentinel recorded a missed attestation.

Fix

The test now waits for one warm-up slot and then waits for the observed checkpoint number to advance before capturing initialSlot. That keeps startup pipelining behavior out of the strict sentinel assertion window while preserving the test's actual coverage: once the network is past warm-up, every validator should be observed attesting or proposing as expected.

Verification

  • yarn format end-to-end
  • yarn build
  • yarn workspace @aztec/end-to-end test:e2e e2e_p2p/multiple_validators_sentinel.parallel.test.ts -t 'collects attestations for all validators on a node'

@spalladino spalladino added the ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure label May 26, 2026
@spalladino
Copy link
Copy Markdown
Contributor Author

Grind run green on http://ci.aztec-labs.com/1779889164003366

@spalladino spalladino enabled auto-merge (squash) May 27, 2026 14:21
@spalladino spalladino changed the title fix: wait for checkpoint before sentinel assertions test(e2e): wait for checkpoint before sentinel assertions in e2e_p2p_multiple_validators_sentinel May 27, 2026
@spalladino spalladino merged commit 3f9b67e into merge-train/spartan May 27, 2026
26 of 32 checks passed
@spalladino spalladino deleted the spl/fix-sentinel-warmup branch May 27, 2026 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-fail-fast Sets NO_FAIL_FAST in the CI so the run is not aborted on the first failure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants