fix(ci): don't serve cached results for disabled-cache test commands#23658
Merged
Conversation
Exercises run_test_cmd end-to-end against an isolated real redis: a normal cached command is SKIPPED without executing, while a disabled-cache command with the same stored pass is run anyway (cache bypassed). Guards against regressing the disabled-cache check in the result-cache read.
charlielye
approved these changes
May 29, 2026
ludamad
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_test_cmd's per-command result cache keyed on the command string alone and never inspected thedisabled-cachemarker. Commands taggeddisabled-cache(e.g. all TXE tests onmerge-train/fairies, pernoir-projects/noir-contracts/bootstrap.sh::test_cmds) were therefore served stale cached passes and skipped — even though the sibling layerfilter_cached_test_cmdalready honors the marker.Consequence: aztec-nr-level changes such as contract demotions merged without their TXE tests ever running. See the test-engine log http://ci.aztec-labs.com/b893262917583a30 for the auth-registry demotion PR #23106, which logged 709 SKIPPED / 0 executed.
Fix: bypass the result cache for
disabled-cachecommands inrun_test_cmd, mirroringfilter_cached_test_cmd's marker check. No behavior change for other commands.