Skip to content

docs: complete and correct the proving historic state page#23830

Merged
critesjosh merged 5 commits into
nextfrom
docs/prove-historic-state-completeness
Jun 22, 2026
Merged

docs: complete and correct the proving historic state page#23830
critesjosh merged 5 commits into
nextfrom
docs/prove-historic-state-completeness

Conversation

@critesjosh

@critesjosh critesjosh commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Updates the Proving historic state page (docs/docs-developers/docs/aztec-nr/framework-description/advanced/how_to_prove_history.md) for completeness and accuracy against noir-projects/aztec-nr/aztec/src/history/.

Verification

  • Every function signature, module path, and claim checked against source.
  • Reviewed twice by a second model (plan + implementation); flagged items verified against source and fixed.
  • cspell passes; cross-reference link matches its heading slug.

Add the missing history::storage module (public_storage_historical_read),
a data-availability caveat (pruning/archive node, 24h anchor window), and a
block-header getter section. Fix the Archive-tree framing (inclusion proofs
are against the note hash / nullifier / public data tree roots committed in a
block header; the Archive tree holds block-header hashes), and correct the
nullifier helpers to say siloed rather than raw nullifier.
@critesjosh critesjosh marked this pull request as ready for review June 10, 2026 14:33

@ciaranightingale ciaranightingale left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small clarifications that you can address where you think they are needed

critesjosh and others added 4 commits June 22, 2026 11:54
Co-authored-by: ciaranightingale <52419674+ciaranightingale@users.noreply.github.com>
Distinguish reading historical public storage from a private function
(no enqueued public call needed) from reading the live value, and explain
that PublicImmutable/DelayedPublicMutable private reads go through
public_storage_historical_read via WithHash. Define what a siloed
nullifier is for the history table. Mirror the same changes into the
v5.0.0-rc.1 versioned page.
@critesjosh critesjosh added this pull request to the merge queue Jun 22, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 22, 2026
@critesjosh critesjosh added this pull request to the merge queue Jun 22, 2026
Merged via the queue into next with commit 403956b Jun 22, 2026
21 of 22 checks passed
@critesjosh critesjosh deleted the docs/prove-historic-state-completeness branch June 22, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants