chore(prover-client): demote empty addTxs log from warn to verbose#24591
Closed
AztecBot wants to merge 1 commit into
Closed
chore(prover-client): demote empty addTxs log from warn to verbose#24591AztecBot wants to merge 1 commit into
AztecBot wants to merge 1 commit into
Conversation
AztecBot
added
ci-draft
This was referenced Jul 7, 2026
spalladino
pushed a commit
that referenced
this pull request
Jul 7, 2026
…24593) `CheckpointSubTreeOrchestrator.addTxs` logs `Provided no txs to addTxs.` at **warn** level, but this path is expected control flow, not an anomaly: `checkpoint-prover.ts` calls `this.subTree.addTxs(processed)` unconditionally for every block in the checkpoint, so every empty block hits this early return (the empty block is then finalized via `setBlockCompleted`). On low-traffic networks this fires constantly — ~100 times in 4h on staging-internal — polluting warn-level log reviews with noise. Demote it to `verbose`. No behavior change; no tests assert on this message. Replaces #24591 and #24592 (closed), per request to land this as a single PR via the spartan-v5 merge train. Spotted during a staging-internal log review requested by @spalladino in Slack. --- *Created by [claudebox](https://claudebox.work/v2/sessions/ac050bae673edac4) · group: `slackbot`*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProvingOrchestrator.addTxslogsProvided no txs to orchestrator addTxs.at warn level, but this path is expected control flow, not an anomaly:checkpoint-prover.tscallsaddTxs(processed)unconditionally for every block in the checkpoint, so every empty block hits this early return (the empty block is then finalized viasetBlockCompleted). On low-traffic networks this fires constantly — ~100 times in 4h on staging-internal — polluting warn-level log reviews with noise.Demote it to
verbose. No behavior change; no tests assert on this message.Same demotion for the
v5-nextcounterpart (checkpoint-sub-tree-orchestrator.ts) is opened separately againstv5-next.Spotted during a staging-internal log review requested by @spalladino in Slack.
Created by claudebox · group:
slackbot