clean up contract leaf is empty checks#716
Merged
Merged
Conversation
Maddiaa0
approved these changes
May 30, 2023
Member
Maddiaa0
left a comment
Maddiaa0
left a comment
There was a problem hiding this comment.
lgtm, once the linting stuff is taken care of lets merge!
LHerskind
reviewed
May 30, 2023
| { contract_data.contract_address, contract_data.portal_contract_address, contract_data.function_tree_root }, | ||
| GeneratorIndex::CONTRACT_LEAF); | ||
| if (contract_data.contract_address != 0) { | ||
| auto contract_leaf = contract_data.hash(); |
Contributor
There was a problem hiding this comment.
Do we need the contract_leaf for anything but the update_element()? Seems like it could be moved into the if or moved all the way in.
Similar for some of the above.
rahul-kothari
force-pushed
the
rk/is_empty_contractdata
branch
from
c14774d to
9ec0d38
Compare
rahul-kothari
force-pushed
the
rk/is_empty_contractdata
branch
from
9ec0d38 to
976cfd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #459
Checklist: