Skip to content

Using bb ECDSA#954

Merged
benesjan merged 1 commit intomasterfrom
janb/using-bb-ecdsa
Jul 13, 2023
Merged

Using bb ECDSA#954
benesjan merged 1 commit intomasterfrom
janb/using-bb-ecdsa

Conversation

@benesjan
Copy link
Copy Markdown
Contributor

@benesjan benesjan commented Jul 4, 2023

Description

Fixes #913

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@benesjan benesjan force-pushed the janb/using-bb-ecdsa branch from 570518d to 2d1aef1 Compare July 13, 2023 13:46
@benesjan benesjan requested a review from PhilWindle July 13, 2023 14:19
@benesjan benesjan enabled auto-merge (squash) July 13, 2023 14:20
Copy link
Copy Markdown
Collaborator

@PhilWindle PhilWindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@benesjan benesjan merged commit 0efa8f1 into master Jul 13, 2023
@benesjan benesjan deleted the janb/using-bb-ecdsa branch July 13, 2023 14:59
spalladino added a commit that referenced this pull request Jul 14, 2023
spalladino added a commit that referenced this pull request Jul 18, 2023
spalladino added a commit that referenced this pull request Jul 19, 2023
…in account contracts (#1080)

* Log nargo version when compiling

* Fix get_note and emit encrypted log on initialisation

* Use ecdsa private key for signing instead of encryption key (d'oh!)

* Add noir debug call for arrays with text

* Revert "chore: using bb ecdsa (#954)"

This reverts commit 0efa8f1.

* Properly inject invalid signing key for failing test

* Reenable signature verification in ecdsa contract

* Split SchnorrAccount into single and multi key flavours

* Apply suggestions by @benesjan
iakovenkos added a commit that referenced this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update ECDSA signer with bb signature once fixed

2 participants