fix: token naming issue#9950
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
sklppy88
left a comment
sklppy88
left a comment
There was a problem hiding this comment.
How married are you to the new name ? 😄
@sklppy88 do you hate it? |
Docs PreviewHey there! 👋 You can check your preview at https://67351ad26de3353ed3da61af--aztec-docs-dev.netlify.app |
Hate is a strong word for sure, but it feels a bit off. Can't think of anything better now and I do agree it's better than the last hence the approval.
But I think a better longer term solution would be to—just like how we coined a new term for "Shared" state—make a public facing term that we can use when referring to "partial notes" that clearly invokes the idea of the thing as a whole with the term itself staying somewhat simple. |
benesjan
force-pushed
the
11-13-refactor_token_refunds_cleanup
branch
from
3d4724b to
4bb0b7d
Compare
benesjan
force-pushed
the
11-13-fix_token_naming_issue
branch
from
e6f37b9 to
b241173
Compare
@sklppy88 you are being severely judged now. |
Merge activity
|
benesjan
changed the base branch from
11-13-refactor_token_refunds_cleanup
to
graphite-base/9950
benesjan
force-pushed
the
11-13-fix_token_naming_issue
branch
from
b241173 to
f719697
Compare
benesjan
force-pushed
the
11-13-fix_token_naming_issue
branch
from
f719697 to
6079ecc
Compare
* master: (245 commits) chore: pull signed bitshifts from sync PR (#9939) chore: pull frontend changes from sync PR (#9935) feat: separate bytecode logs from unencrypted logs (#9891) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: token naming issue (#9950) feat: multiplier oracle (#9902) refactor: token refunds cleanup (#9943) chore: Use stack based recursion instead of function recursion (#9947) feat: parallelize DIE pass (#9933) feat(avm): Simulator enforces integral tag for DIV and field tag for FDIV (#9944) chore(avm): bugfixing witness generation for add, sub, mul for FF (#9938) feat: Google Cloud Kubernetes cluster + AWS Firewall Rules (#9915) chore: nuking ancient redundant test (#9941) fix: include 'master' version for aztec-up scripts (#9940) chore: fixing test contract fixture (#9909) refactor: token naming cleanup (#9904) chore: pull SSA parser from sync PR (#9928) ...
3 participants
_prepare_transfer_to_private function was used even in flows which are not a transfer (typically during minting). For this reson I renamed the function to _prepare_private_balance_increase.