Skip to content

“Add All to Batch” on the Operator page queues hundreds of empty transactions #86

@y3v63n

Description

@y3v63n

What's happening

On the Operator Commission page (/operator), the number of transactions added to the batch when an operator clicks "Add All to Batch" is far higher than the number of rows visible on the page.

Image

An operator sees 25 splits (the ones with actual rewards to claim) in the visible list. But when they click "Add All to Batch", the transaction queue fills up with 174 entries. Most of those extra entries are for delegations that have nothing to claim.

Why this happens

The page shows a list of splits filtered to ones where the operator actually has something to collect above a small "dust" threshold of around half a token.

But the "Add All to Batch" button doesn't use the same filter. It goes through every split that's ever paid the operator and queues a transaction for any split that has even 1 wei of token sitting on it. Since any 0xSplits v2 contract that has been distributed through permanently holds 1 wei of the token, every split that's ever been distributed survives the "Add All" check and gets queued, even when there's nothing to claim from it.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions