Fix crashing when generating 4K outputs#163
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts WgpuContext device creation to avoid crashes when generating 4K outputs by requesting device limits based on the selected adapter rather than using default (more restrictive) limits.
Changes:
- Use
adapter.limits()asrequired_limitswhen requesting the wgpu device. - Replace the non-profiling
DeviceDescriptor::default()call with an explicitDeviceDescriptorthat applies the same requested limits.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| info!("wgpu adapter info: {:?}", adapter.get_info()); | ||
| let required_limits = adapter.limits(); | ||
|
|
There was a problem hiding this comment.
required_limits is assigned from adapter.limits() (i.e., the adapter’s maximum supported limits). The variable name reads like “minimum required limits”, which is easy to misinterpret when debugging device-creation failures; consider renaming to something like adapter_limits/requested_limits to reflect what’s being passed to required_limits:.
| @@ -183,7 +184,14 @@ impl WgpuContext { | |||
| .unwrap(); | |||
| #[cfg(not(feature = "profiling"))] | |||
| let (device, queue) = adapter | |||
| .request_device(&wgpu::DeviceDescriptor::default()) | |||
| .request_device(&wgpu::DeviceDescriptor { | |||
| label: None, | |||
| required_features: wgpu::Features::empty(), | |||
| required_limits, | |||
| memory_hints: wgpu::MemoryHints::default(), | |||
| trace: wgpu::Trace::Off, | |||
| experimental_features: wgpu::ExperimentalFeatures::disabled(), | |||
| }) | |||
There was a problem hiding this comment.
The DeviceDescriptor fields are duplicated across the profiling and not(profiling) branches (label, limits, memory_hints, trace, experimental_features). Consider constructing a shared base descriptor (or using ..Default::default() with only the differing required_features) to reduce the chance of the branches drifting if fields are added/changed later.
|
Thanks! Waiting checks to pass for merging! |
It's because the default device buffer limits is too small for 4K output. Just use adapter's limits.