Fix incorrect lat lon ordering#142
Closed
Yuxian1113 wants to merge 1 commit intoAzure-Samples:mainfrom
Closed
Conversation
Contributor
|
Thanks for raising this issue. I think this is the first time I've seen this sample. Taking a closer look at the code see a couple of issues. The solution you proposed does resolve the issue, however, the original code overall isn't great and needs to be cleaned up a lot more. With this in mind, I'm going to close this PR and make the necessary changes needed to this sample to improve it, and look at getting the tutorial docs updated as well. Thanks again. |
rbrundritt
added a commit
that referenced
this pull request
Aug 29, 2024
Fixed bug reported in PR #142 Cleaned up code a bit and fixed another small bug.
Contributor
|
I've made the updates. It looks like this sample was updated last winter to remove the dependency on the old services module, and whoever made that change, added in a couple of bugs. All corrected now. Thanks again for highlighting this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The camera view was incorrectly showing the ocean instead of Seattle when displaying search results.

Changes Made:
bounds.pushcall to use the correct coordinate format[lat, lon]as required by thefromLatLngsfunction, which sets the camera position.Reason for the Change:
The
fromLatLngsfunction expects coordinates in the[lat, lon]format. Previously, the code passed[lon, lat], causing the camera to focus on an unintended location.After modification:
