Skip to content

This closes #15#16

Merged
IanB111 merged 2 commits intoAzure-Samples:masterfrom
IanB111:master
Mar 2, 2019
Merged

This closes #15#16
IanB111 merged 2 commits intoAzure-Samples:masterfrom
IanB111:master

Conversation

@IanB111
Copy link
Copy Markdown
Collaborator

@IanB111 IanB111 commented Mar 2, 2019

Purpose

Adds Support to create tasks that will be using SPN with a cert to authenticate with AZURESTACK instead of an Admin account

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

Setup SPN with a cert and create data collection tasks against the Azure Stack.
Run the tasks.

What to Check

Verify that the following are valid
Logs show tasks are run successfully and data appears in the log-analyticsworkspace

Other Information

Cleaned up some use of the password or credentials that were unneeded

Updated the scripts to be able to handle using a Cert used for SPN instead of Admin Credentials to sign into AZURESTACK.
Cleaned up some unneeded passing of Admin Credential
Cleaned up password being saved as plain text in info
Some lines were missing the ` marks
@IanB111 IanB111 merged commit ab63700 into Azure-Samples:master Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant