Skip to content

Conversation

@DidunAyodeji
Copy link
Contributor

Second try at updating this repo with a new script.

Updating all Azure AD terms to the Microsoft Entra ID terms in all md files.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

What to Check

The updated changes to Microsoft Entra ID terminology make sense.

Other Information

Here's a link to the Rebrand guidelines. Note that the script doesn't have all the entries in the glossary that mine has. Let me know if you'd like to see my version of the script. https://review.learn.microsoft.com/en-us/entra/fundamentals/how-to-rename-azure-ad?branch=main

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @DidunAyodeji

I left 2 suggestions which would be great to address.
Thanks!

Use [Stack Overflow](http://stackoverflow.com/questions/tagged/msal) to get support from the community.
Ask your questions on Stack Overflow first and browse existing issues to see if someone has asked your question before.
Make sure that your questions or comments are tagged with [`azure-active-directory` `msal` `dotnet`].
Make sure that your questions or comments are tagged with [`microsoft-entra-id` `msal` `dotnet`].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was the "azure-active-directory" tag removed in Stack overflow. It seems to me that it enables people to troubleshoot themselves. I would keep it here (find historical issues?)

Copy link
Contributor Author

@DidunAyodeji DidunAyodeji Jan 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch. I have added this entry to the post-transform section of the script to correct this issue going forward!
@{ Key = '`microsoft-entra-id`'; Value = '`azure-active-directory`' }

Other repos won't have this issue now that I've added that entry. I will manually make the change you've suggested. Thank you!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This readme file has been updated with the correct tag now. Thank you again.

@DidunAyodeji DidunAyodeji merged commit 6554c89 into master Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants