-
Notifications
You must be signed in to change notification settings - Fork 196
Microsoft Entra Rebrand #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit b40bb37.
jmprieur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @DidunAyodeji
I left 2 suggestions which would be great to address.
Thanks!
| Use [Stack Overflow](http://stackoverflow.com/questions/tagged/msal) to get support from the community. | ||
| Ask your questions on Stack Overflow first and browse existing issues to see if someone has asked your question before. | ||
| Make sure that your questions or comments are tagged with [`azure-active-directory` `msal` `dotnet`]. | ||
| Make sure that your questions or comments are tagged with [`microsoft-entra-id` `msal` `dotnet`]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the "azure-active-directory" tag removed in Stack overflow. It seems to me that it enables people to troubleshoot themselves. I would keep it here (find historical issues?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch. I have added this entry to the post-transform section of the script to correct this issue going forward!
@{ Key = '`microsoft-entra-id`'; Value = '`azure-active-directory`' }
Other repos won't have this issue now that I've added that entry. I will manually make the change you've suggested. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This readme file has been updated with the correct tag now. Thank you again.
Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
JM Stack Overflow metadata
Second try at updating this repo with a new script.
Updating all Azure AD terms to the Microsoft Entra ID terms in all md files.
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
What to Check
The updated changes to Microsoft Entra ID terminology make sense.
Other Information
Here's a link to the Rebrand guidelines. Note that the script doesn't have all the entries in the glossary that mine has. Let me know if you'd like to see my version of the script. https://review.learn.microsoft.com/en-us/entra/fundamentals/how-to-rename-azure-ad?branch=main