Modernizing the Bicep for AVM (python) #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates key configuration and documentation details for the functions-quickstart-python-azd project to align with recent changes introduced in the corresponding .NET sample.
- Updated the template version in azure.yaml from 1.0.0 to 1.0.1.
- Modified README.md to replace the SKIP_VNET parameter with VNET_ENABLED and adjust related instructions.
Reviewed Changes
Copilot reviewed 2 out of 17 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| azure.yaml | Updated template version to 1.0.1 to reflect a new release. |
| README.md | Revised parameter naming and instructions for virtual network configuration. |
Files not reviewed (15)
- infra/app/api.bicep: Language not supported
- infra/app/rbac.bicep: Language not supported
- infra/app/storage-Access.bicep: Language not supported
- infra/app/storage-PrivateEndpoint.bicep: Language not supported
- infra/app/vnet.bicep: Language not supported
- infra/core/host/appserviceplan.bicep: Language not supported
- infra/core/host/functions-flexconsumption.bicep: Language not supported
- infra/core/identity/userAssignedIdentity.bicep: Language not supported
- infra/core/monitor/appinsights-access.bicep: Language not supported
- infra/core/monitor/applicationinsights.bicep: Language not supported
- infra/core/monitor/loganalytics.bicep: Language not supported
- infra/core/monitor/monitoring.bicep: Language not supported
- infra/core/storage/storage-account.bicep: Language not supported
- infra/main.bicep: Language not supported
- infra/main.parameters.json: Language not supported
Comments suppressed due to low confidence (1)
azure.yaml:5
- [nitpick] Ensure that the template version update is also documented in the release notes or change logs to maintain clear version tracking.
+ template: functions-quickstart-python-azd@1.0.1
Collaborator
Author
|
@ggailey777 please review |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
nzthiago
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernizing the Bicep for AVM (python)
This is the corresponding change to match
https://github.com/Azure-Samples/functions-quickstart-dotnet-azd/pull/16/files