Skip to content

Simplifying GET logic and allowing null name param like other samples#5

Merged
paulyuk merged 1 commit intoAzure-Samples:mainfrom
paulyuk:hotfix/get-code
Aug 20, 2024
Merged

Simplifying GET logic and allowing null name param like other samples#5
paulyuk merged 1 commit intoAzure-Samples:mainfrom
paulyuk:hotfix/get-code

Conversation

@paulyuk
Copy link
Copy Markdown
Collaborator

@paulyuk paulyuk commented Aug 18, 2024 •
edited
Loading

  • replaced if then multi line logic with simpler default value parameter on the get header
  • allows for name to be null and returns World instead
  • updated readme to match
  • updated http_get test link in readme

@paulyuk
Simplifying GET logic and allowing null name param like other samples
16af044 
Signed-off-by: Paul Yuknewicz <paulyuk@microsoft.com>
@paulyuk paulyuk added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Aug 18, 2024
@paulyuk paulyuk self-assigned this Aug 18, 2024
@paulyuk paulyuk merged commit bcfba4d into Azure-Samples:main Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nzthiago nzthiago Awaiting requested review from nzthiago

@shreyabatra4 shreyabatra4 Awaiting requested review from shreyabatra4

1 more reviewer

@BigMorty BigMorty BigMorty approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@paulyuk paulyuk

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulyuk @BigMorty