Skip to content

minor tweaks#8

Merged
paulyuk merged 2 commits intoAzure-Samples:mainfrom
BigMorty:main
Aug 28, 2024
Merged

minor tweaks#8
paulyuk merged 2 commits intoAzure-Samples:mainfrom
BigMorty:main

Conversation

@BigMorty
Copy link
Copy Markdown
Contributor

Update Readme and azure.yaml

Comment thread README.md
1) Open the terminal, navigate to the project folder, and run the following commands:
Open the terminal, navigate to the project folder, and run the following commands:

#### bash
Copy link
Copy Markdown
Contributor

@ggailey777 ggailey777 Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that my original docs on this are incorrect and the tabs should be Windows | Linux/macOs but I'll fix this when I update readmes (and in the regular Python quickstart too).

Copy link
Copy Markdown
Collaborator

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@ggailey777 ggailey777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change doesn't actually work on a Windows command prompt

Comment thread README.md Outdated
```powershell
py -m venv .venv
.venv\scripts\activate
.venv/scripts/activate
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both ways work on Windows PowerShell

Comment thread README.md Outdated
```cmd
py -m venv .venv
.venv\scripts\activate
.venv/scripts/activate
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't work on Windows command prompt. Can you please revert it?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll definitely be fixing our docs, which I think is the source of this confusion 🙄

@paulyuk paulyuk merged commit 2045541 into Azure-Samples:main Aug 28, 2024
Copy link
Copy Markdown
Collaborator

@paulyuk paulyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants