Skip to content

Add configuration for ready-to-go downloaded sample - python web app#11

Merged
rayluo merged 1 commit intoAzure-Samples:masterfrom
archieag:patch-1
Jan 14, 2020
Merged

Add configuration for ready-to-go downloaded sample - python web app#11
rayluo merged 1 commit intoAzure-Samples:masterfrom
archieag:patch-1

Conversation

@archieag
Copy link
Copy Markdown
Contributor

No description provided.

@archieag
Copy link
Copy Markdown
Contributor Author

#sign-off

@rayluo rayluo requested a review from jmprieur January 13, 2020 22:14
Copy link
Copy Markdown
Contributor

@rayluo rayluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@archieag Unlike the docs repo, this sample repo requires a manual merge, which I will happily do that for you. :-)

The intention of this PR makes sense to me, but I'm not familiar with those content. If @jmprieur would also double check all those keywords, that would be great. Otherwise, I think we will still merge it in tomorrow.

],
"codeConfigurations": [
{
"settingFile": "/app_config.py",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: If you prefer, you can remove those excess indentation, in order to match the existing indentation elsewhere in this file. This is technically optional, though. It is up to you.

Copy link
Copy Markdown
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @archieag !

@rayluo rayluo merged commit e766604 into Azure-Samples:master Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants