Skip to content

Adding apps.json to take the quickstart into account in the portal#3

Merged
jmprieur merged 1 commit intomasterfrom
addingAppsJsonForPortalQuickstart
Sep 25, 2019
Merged

Adding apps.json to take the quickstart into account in the portal#3
jmprieur merged 1 commit intomasterfrom
addingAppsJsonForPortalQuickstart

Conversation

@jmprieur
Copy link
Copy Markdown
Contributor

No description provided.

@jmprieur
Copy link
Copy Markdown
Contributor Author

@abhidnya13 @rayluo FYI

{
"id": "b340eb25-3456-403f-be2f-af7a0d370277",
"type": "Scope",
"x-ms-name": "User.ReadBasic.All"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in prevision of the evolutions discussed recently by email.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. So this apps.json is the metadata only used by the Portal? For such kind of file that is not used by this repo itself, ideally we would like to have a comment to document so, to avoid future confusion.
Shall we try add a second line into this file, like this?

{
    "comment": "This file will be used by App Registration Portal",
    "Sample": {
        ...
    },
    ...
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I'm not sure what the portal will do if we add another attribute in the json file. Probably ok, but we need to check with Shiv.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough. In that sense, @shivbijlani should be the one who reviewed this PR in the first place. Nonetheless, CCing him here. :-)

@jmprieur jmprieur merged commit bcd0f39 into master Sep 25, 2019
@jmprieur jmprieur deleted the addingAppsJsonForPortalQuickstart branch September 25, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants