Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Refactor/bg 2 ingress - DO NOT MERGE#139

Merged
rguthriemsft merged 11 commits intomasterfrom
refactor/bg-2-ingress
Mar 21, 2019
Merged

Refactor/bg 2 ingress - DO NOT MERGE#139
rguthriemsft merged 11 commits intomasterfrom
refactor/bg-2-ingress

Conversation

@rguthriemsft
Copy link
Copy Markdown
Contributor

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@rguthriemsft rguthriemsft requested a review from dcaro March 11, 2019 22:58
@rguthriemsft rguthriemsft changed the title Refactor/bg 2 ingress Refactor/bg 2 ingress - DO NOT MERGE Mar 13, 2019
Copy link
Copy Markdown
Contributor

@dcaro dcaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rguthriemsft rguthriemsft merged commit d268676 into master Mar 21, 2019
@rguthriemsft rguthriemsft deleted the refactor/bg-2-ingress branch March 21, 2019 19:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants