Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Corrected example ACR URL comment.#164

Merged
rguthriemsft merged 1 commit intoAzure-Samples:masterfrom
caseywatson:patch-1
May 16, 2019
Merged

Corrected example ACR URL comment.#164
rguthriemsft merged 1 commit intoAzure-Samples:masterfrom
caseywatson:patch-1

Conversation

@caseywatson
Copy link
Copy Markdown
Contributor

Purpose

Example incorrectly provides azureacr.io as the root ACR domain. This typo has caused difficult-to-diagnose issues when working through the DevOps OH. Corrected root ACR domain to be azurecr.io.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Update the values.yaml to use an ACR image path using the corrected ACR domain name (azurecr.io).
  • Deploy the Helm chart.

What to Check

  • That the example root ACR domain has been corrected to azurecr.io.

Other Information

Example incorrectly provides azureacr.io as the root ACR domain. This typo has caused difficult-to-diagnose issues when working through the DevOps OH. Corrected root ACR domain to be azurecr.io.
@rguthriemsft rguthriemsft merged commit 0e684e7 into Azure-Samples:master May 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants