Skip to content
This repository was archived by the owner on Nov 16, 2023. It is now read-only.

Separate trips unit / integration tests#63

Merged
dtzar merged 7 commits intomasterfrom
tripsunit
Sep 14, 2018
Merged

Separate trips unit / integration tests#63
dtzar merged 7 commits intomasterfrom
tripsunit

Conversation

@dtzar
Copy link
Copy Markdown

@dtzar dtzar commented Sep 14, 2018 •
edited
Loading

Purpose

  • Refactors the common test go file into a centralized utility
  • Separates the healthcheck route into a separate test and all integration tests which require the db into the /test/integration folder
  • Adds go.mod for go get dependency installation with golang 1.11.0
  • Updates docker container to build using 1.11.0 and without glide

@dtzar dtzar requested a review from rguthriemsft September 14, 2018 17:27
rguthriemsft
rguthriemsft approved these changes Sep 14, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@rguthriemsft rguthriemsft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dtzar dtzar merged commit f83e99f into master Sep 14, 2018
@dtzar dtzar deleted the tripsunit branch September 14, 2018 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@rguthriemsft rguthriemsft rguthriemsft approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dtzar @rguthriemsft