Skip to content

Fixes for week 1 examples#12

Merged
pamelafox merged 4 commits intoAzure-Samples:mainfrom
pamelafox:fixweekone
Feb 24, 2026
Merged

Fixes for week 1 examples#12
pamelafox merged 4 commits intoAzure-Samples:mainfrom
pamelafox:fixweekone

Conversation

@pamelafox
Copy link
Collaborator

Purpose

This PR will include fixes needed to get Week 1 examples working locally and in Codespaces.
This will be updated after all examples are verified.

@pamelafox
Copy link
Collaborator Author

All examples run except workflow examples that are out-of-date and are fixed in subsequent PRs, so am removing from main for now.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make the Week 1 examples work locally and in Codespaces by adjusting dependencies and the devcontainer build environment, but it also removes several workflow example scripts that are referenced in documentation.

Changes:

  • Updated agent-framework-* git dependency pins and enabled uv prerelease resolution.
  • Updated the devcontainer image to install Rust tooling for building Rust-based Python dependencies.
  • Removed three workflow example scripts (workflow_basic.py, workflow_hitl.py, workflow_magenticone.py).

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Updates Agent Framework git pins and adds uv prerelease config.
.devcontainer/Dockerfile Installs Rust toolchain to support building Rust-based Python packages in the container.
examples/workflow_basic.py Deletes the basic workflow example script.
examples/workflow_hitl.py Deletes the HITL workflow example script.
examples/workflow_magenticone.py Deletes the MagenticOne workflow example script.
Comments suppressed due to low confidence (4)

examples/workflow_basic.py:1

  • This example script is being deleted, but it is still referenced from README.md (and there are Spanish equivalents under examples/spanish). That will leave broken links and removes a Week 1 workflow example rather than fixing it. Either restore/update this example (preferred if Week 1 expects it) or update the docs/example index to reflect the removal/move.
    examples/workflow_hitl.py:1
  • This example script is being deleted, but it is still referenced from README.md (and there are Spanish equivalents under examples/spanish). That will leave broken links and removes the HITL workflow example rather than fixing it. Either restore/update this example or update the documentation/example listing to match the new location/removal.
    examples/workflow_magenticone.py:1
  • This example script is being deleted, but it is still referenced from README.md (and there are Spanish equivalents under examples/spanish). That will leave broken links and removes the MagenticOne workflow example rather than fixing it. Either restore/update this example or update the documentation/example listing to match the new location/removal.
    .devcontainer/Dockerfile:9
  • The curl https://sh.rustup.rs | sh pattern executes a remote installer script from sh.rustup.rs with root privileges during the devcontainer build without any integrity verification or pinning. If the remote endpoint or its supply chain were compromised, this would give an attacker arbitrary code execution in developer environments and the ability to tamper with tools or checked-out source. Prefer installing Rust via a distribution package or a pinned, checksummed installer/image instead of executing a mutable remote script at build time.
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 11 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pamelafox pamelafox merged commit 179a294 into Azure-Samples:main Feb 24, 2026
5 checks passed
@pamelafox pamelafox deleted the fixweekone branch February 24, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants