Conversation
wenxuan0923
approved these changes
Feb 13, 2026
wenxuan0923
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the installation logic for several core components (CNI, containerd, Kubernetes binaries, and kubelet) to use new utility functions for file handling and atomic writes, and to streamline the download and extraction of remote tarballs. The changes improve reliability, maintainability, and atomicity of file operations during installation.
Key changes include:
Refactoring file operations and atomic writes:
utilio.WriteFilefunction for writing configuration, service, and kubeconfig files atomically and with correct permissions inkubelet_installer.goandcontainerd_installer.go. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Streamlining remote tarball downloads and extraction:
utilio.DecompressTarGzFromRemotefunction, which streams and extracts files directly from remote sources for CNI, containerd, and Kubernetes binaries. This reduces disk usage and simplifies error handling. [1] [2] [3]Installer method signature updates:
context.Contextparameter, allowing for better cancellation and timeout handling during installation steps. [1] [2] [3] [4]Dependency and import changes:
github.com/google/renameio/v2ingo.modto support atomic file writing, and imported the newutiliopackage in affected files. [1] [2] [3] [4] [5]These changes collectively improve robustness and maintainability of the installation process across multiple system components.