[ARO-26611] Add workaround controller for copyfail to mitigate control plane nodes#4808
Merged
cloudygreybeard merged 4 commits intomasterfrom May 1, 2026
Merged
[ARO-26611] Add workaround controller for copyfail to mitigate control plane nodes#4808cloudygreybeard merged 4 commits intomasterfrom
cloudygreybeard merged 4 commits intomasterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “copy fail” mitigation workaround intended to protect control plane nodes (skipping FIPS clusters), and updates the workaround controller interface to support context + error-returning requirement checks.
Changes:
- Extend
Workaround.IsRequiredto acceptcontext.Contextand return(bool, error); update controller logic and mocks accordingly. - Introduce
aro.workaround.copyfail.enabledoperator flag (default enabled). - Add
copyfailworkaroundimplementation (MachineConfig applyinginitcall_blacklist=algif_aead_init) plus unit tests.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/util/mocks/operator/controllers/workaround/workaround.go | Updates gomock stub to match new IsRequired(ctx, ...) (bool, error) signature. |
| pkg/operator/flags.go | Adds CopyFailWorkaroundEnabled flag and defaults it to true. |
| pkg/operator/controllers/workaround/workaround_controller_test.go | Updates gomock call arity for IsRequired (now takes ctx), but needs return-value fixes. |
| pkg/operator/controllers/workaround/workaround_controller.go | Updates reconcile loop to call new IsRequired signature and aggregate errors. |
| pkg/operator/controllers/workaround/workaround.go | Updates the Workaround interface signature for IsRequired. |
| pkg/operator/controllers/workaround/systemreserved.go | Updates systemreserved workaround to new IsRequired signature. |
| pkg/operator/controllers/workaround/copyfailworkaround.go | Adds the new copyfail workaround implementation using a master MachineConfig. |
| pkg/operator/controllers/workaround/copyfailworkaround_test.go | Adds unit tests for the copyfail workaround enablement/FIPS/error behaviors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
edisonLcardenas
approved these changes
May 1, 2026
yjst2012
approved these changes
May 1, 2026
Collaborator
yjst2012
left a comment
There was a problem hiding this comment.
LGTM, thanks for the idea and quick implementation, appreciate it!
pepedocs
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-26611
What this PR does / why we need it:
Adds a workaround controller to add a mitigation for copyfail to control planes, exempting FIPS ones since they can't be mitigated via this method
Test plan for issue:
Manual testing