ARO-26564: fix: include condition name in provisioning timeout errors

[nikhil-thomas]

Which issue this PR addresses: ARO-26564

Fixes https://redhat.atlassian.net/browse/ARO-26564

Fixes

What this PR does / why we need it:

When a condition step times out and is not in the
timeoutConditionErrors map, the error returned was the raw
"timed out waiting for the condition" with no indication of
which condition failed.

• Wrap the original error with the condition function name in
  enrichConditionTimeoutError() when the function is not found
  in the timeoutConditionErrors map

  ARO-RP/pkg/util/steps/condition.go

  Line 26 in fc8e2af

  var timeoutConditionErrors = map[string]string{

• Use fmt.Errorf("condition step failed: %s: %w", ...) rather
  than fmt.Errorf("timed out waiting for condition %s", ...)
  because using a distinct prefix avoids the redundant output of
  timed out waiting for condition X: timed out waiting for the condition
• Update unit and integration tests to match the new error format

Test plan for issue:

How did you test that this PR works?

• Are there unit tests? - i have run the unit tests.

Is there any documentation that needs to be updated for this PR?

How do you know this will function as expected in production?

[iormungand]

• Confirmed all Conditions in install.go are now covered
• Good error messages
• Added better information for any future Conditions missing from timeoutConditionErrors map
• Tests all run

LGTM

[iormungand]

Looks like perhaps this ticket is asking for the wrong thing:
https://redhat-internal.slack.com/archives/C02ULBRS68M/p1779247378561709

These errors are not actionable by the user - incorrect configuration should be caught by preflight, rather than once they have timed out. Surfacing details could make the problem worse if they try to use an LLM.

Looks like we really just need to write a log line, and put comments in the code to document the exception being made.

[nikhil-thomas]

/help

[ventifus]

lgtm