e2e script improvement #1#1488
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR addresses:
Bug: ACS-Test does Garbage Collection every 3 days. This deleted the MC RG corresponding to agentbaker_e2e cluster, however, the cluster itself isn't deleted, causing an error while retrieving cluster-info referring to a deleted MC RG.
Fix: Added logic to check if cluster exists and MC RG doesn't and carry out proper cleanup
Bug: Logic to check if Pod successfully runs on a newly joined Node checks as -> kubectl get pods -o wide | grep 'Running', which can result in false-positive w.r.t any Running pod.
Fix: grep pod first, then test for 'Running'
Improvement: Randomize the Pod container name to avoid errors in concurrent runs