doc: Registering calico-windows-v3.17.1#529
Conversation
| "Component": { | ||
| "Type": "other", | ||
| "Other": { | ||
| "Name": "CalicoWindows", |
There was a problem hiding this comment.
- how should we relate the
CalicoWindowsto the calico component we are using? - how can we verify its correctness? is this tool useful? https://docs.opensource.microsoft.com/tools/cg/cgmanifest.html#how-can-i-test-my-cgmanifestjson-file cgmanifest.json
There was a problem hiding this comment.
For #1, can you add more details for your question? From my understanding, it is just a name. The source URL is more important.
For #2, when creating this PR with this file cgmanifest.json, the reviewer microsoftopensource is automatically recommended so I think that it should be good. And I will wait the review from Microsoft opensource team. It seems like building the tool needs more time. We can do it later if it is worth.
There was a problem hiding this comment.
Hi I work in the Open Source Engineering team
- In the case of "other" components as @AbelHu mention the most important part is the URL, think about the name as the display name.
- The cgmanifest looks good to me, but you can use to tool to validate that the file is going to be parsed successfully by our detectors.
There was a problem hiding this comment.
@jcfiorenzano Thanks for your review. We will follow the guidance to merge the PR and then check the alerts.
There was a problem hiding this comment.
@jcfiorenzano may I ask do we need to update the version and DownloadUrl every time we have an update of this component? thanks
|
ping @microsoftopensource |
./vhdbuilder/cgmanifest.jsonto register this third party package.