Skip to content

doc: Registering calico-windows-v3.17.1#529

Merged
AbelHu merged 1 commit into
masterfrom
abelch/calico-registration
Jan 26, 2021
Merged

doc: Registering calico-windows-v3.17.1#529
AbelHu merged 1 commit into
masterfrom
abelch/calico-registration

Conversation

@AbelHu
Copy link
Copy Markdown
Member

@AbelHu AbelHu commented Jan 13, 2021

"Component": {
"Type": "other",
"Other": {
"Name": "CalicoWindows",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. how should we relate the CalicoWindows to the calico component we are using?
  2. how can we verify its correctness? is this tool useful? https://docs.opensource.microsoft.com/tools/cg/cgmanifest.html#how-can-i-test-my-cgmanifestjson-file cgmanifest.json

Copy link
Copy Markdown
Member Author

@AbelHu AbelHu Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For #1, can you add more details for your question? From my understanding, it is just a name. The source URL is more important.
For #2, when creating this PR with this file cgmanifest.json, the reviewer microsoftopensource is automatically recommended so I think that it should be good. And I will wait the review from Microsoft opensource team. It seems like building the tool needs more time. We can do it later if it is worth.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I work in the Open Source Engineering team

  1. In the case of "other" components as @AbelHu mention the most important part is the URL, think about the name as the display name.
  2. The cgmanifest looks good to me, but you can use to tool to validate that the file is going to be parsed successfully by our detectors.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcfiorenzano Thanks for your review. We will follow the guidance to merge the PR and then check the alerts.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcfiorenzano may I ask do we need to update the version and DownloadUrl every time we have an update of this component? thanks

@AbelHu
Copy link
Copy Markdown
Member Author

AbelHu commented Jan 14, 2021

ping @microsoftopensource

@AbelHu AbelHu merged commit 097c33c into master Jan 26, 2021
@AbelHu AbelHu deleted the abelch/calico-registration branch March 3, 2021 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants