Merged
Conversation
SriHarsha001
requested review from
AbelHu,
AlisonB319,
Devinwong,
UtheMan,
anujmaheshwari1,
bravebeaver,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
smith1511,
timmy-wright and
zachary-bailey
as code owners
Devinwong
approved these changes
Apr 11, 2025
Contributor
|
No changes to cached containers or packages on Windows VHDs |
yewmsft
approved these changes
Apr 11, 2025
lilypan26
approved these changes
Apr 11, 2025
ganeshkumarashok
pushed a commit
that referenced
this pull request
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
feature
What this PR does / why we need it:
This PR adds a function enableLocalDNS to cse_config file. This function is called from cse_main.sh and checks if localdns should be enabled by calling shouldEnableLocalDNS defined in cse_helper.sh. It returns 0 if localdns is enabled successfully or if it should not be enabled. It also returns a non-zero value if localdns should be enabled but there was a failure in enabling it.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: