enable shellspec running in a container#6239
Merged
Conversation
Devinwong
commented
Apr 20, 2025
This reverts commit fb09266.
Contributor
|
No changes to cached containers or packages on Windows VHDs |
Devinwong
requested review from
UtheMan,
anujmaheshwari1,
cameronmeissner,
ganeshkumarashok and
juan-lee
as code owners
Devinwong
requested review from
AbelHu,
AlisonB319,
bravebeaver,
djsly,
junjiezhang1997,
lilypan26,
phealy,
r2k1,
smith1511,
timmy-wright and
zachary-bailey
as code owners
Contributor
|
cool to see this working! I'm excited to try this out locally |
cameronmeissner
approved these changes
Apr 28, 2025
ganeshkumarashok
pushed a commit
that referenced
this pull request
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind test
What this PR does / why we need it:
Enable shellspec running in a container so that it can support all platforms (WSL, Mac, etc.)
Updated readme to reflect to the changes.
Which issue(s) this PR fixes:
Fixes #5322
Requirements:
Special notes for your reviewer:
Release note: