fix: enabling waagent root password removal logic again for Ubuntu#7780
Merged
fix: enabling waagent root password removal logic again for Ubuntu#7780
Conversation
djsly
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
timmy-wright
approved these changes
Feb 3, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the CIS hardening script behavior around Azure Linux Agent (waagent) root password handling on Ubuntu images.
Changes:
- Adds a clarifying comment describing what
configureAzureAgentdoes (setting waagent to not delete the root password on first boot). - Disables the call to
configureAzureAgentinsideapplyCIS, effectively reverting to waagent’s default root password deletion behavior (unless configured elsewhere).
Comment on lines
+327
to
+328
| # configureAzureAgent -- Disabling this for now, until we sync with waagent team on desired behavior. | ||
|
|
There was a problem hiding this comment.
The PR description says this change is about keeping the Ubuntu root password by disabling waagent’s removal logic, but the code change here does the opposite: commenting out configureAzureAgent stops setting Provisioning.DeleteRootPassword=n, which means waagent will be free to delete the root password on first boot. Please clarify/update either the PR description or the code so they match the intended behavior.
cameronmeissner
approved these changes
Feb 3, 2026
djsly
changed the title
djsly
changed the title
jepio
approved these changes
Feb 4, 2026
mxj220
pushed a commit
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Reverting logic where the root password on Ubuntu was kept (disabling waagent's removal logic)
This PR changes the CIS hardening script behavior around Azure Linux Agent (waagent) root password handling on Ubuntu images.
Changes: