Skip to content

fix: revert create new field kubelet_cmd_flags which can replace kubelet_flags#7782

Merged
awesomenix merged 1 commit intomainfrom
revert-7771-nishp/use/kubecmdflags
Feb 4, 2026
Merged

fix: revert create new field kubelet_cmd_flags which can replace kubelet_flags#7782
awesomenix merged 1 commit intomainfrom
revert-7771-nishp/use/kubecmdflags

Conversation

@awesomenix
Copy link
Contributor

Reverts #7771

@github-actions
Copy link
Contributor

github-actions bot commented Feb 4, 2026

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed❌ failed (2)Feb 4, 2026, 2:58 AM

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request reverts PR #7771, which had introduced a new kubelet_cmd_flags field to the KubeletConfig protobuf message. The revert removes this field and restores the codebase to use only the original kubelet_flags map-based approach.

Changes:

  • Removed the kubelet_cmd_flags string field from the KubeletConfig protobuf message
  • Updated generated protobuf Go code to reflect the field removal
  • Simplified the getKubeletFlags helper function to only use the map-based kubelet_flags
  • Updated tests to use KubeletFlags map instead of the now-removed KubeletCmdFlags string field
  • Removed unused imports from test files

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
aks-node-controller/proto/aksnodeconfig/v1/kubelet_config.proto Removed kubelet_cmd_flags field (field 9) from KubeletConfig message
aks-node-controller/pkg/gen/aksnodeconfig/v1/kubelet_config.pb.go Auto-generated code updated to remove KubeletCmdFlags field and getter method
aks-node-controller/proto/README.md Documentation updated to remove references to kubelet_cmd_flags
aks-node-controller/parser/parser_test.go Test updated to use KubeletFlags map instead of KubeletCmdFlags string; removed unused imports
aks-node-controller/parser/helper_test.go Test simplified to use inline map definition; removed unused imports and variables
aks-node-controller/parser/helper.go Simplified getKubeletFlags function to only handle map-based flags
aks-node-controller/Makefile Unrelated changes to platform specifications and branch reference

@awesomenix awesomenix force-pushed the revert-7771-nishp/use/kubecmdflags branch from fcadf20 to 7f8a313 Compare February 4, 2026 02:58
@awesomenix awesomenix changed the title Revert "fix: create new field kubelet_cmd_flags which can replace kubelet_flags" fix: revert create new field kubelet_cmd_flags which can replace kubelet_flags Feb 4, 2026
@awesomenix awesomenix merged commit 5acbf9b into main Feb 4, 2026
20 of 30 checks passed
@awesomenix awesomenix deleted the revert-7771-nishp/use/kubecmdflags branch February 4, 2026 03:00
mxj220 pushed a commit that referenced this pull request Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments