fix: revert create new field kubelet_cmd_flags which can replace kubelet_flags#7782
Merged
awesomenix merged 1 commit intomainfrom Feb 4, 2026
Merged
Conversation
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request reverts PR #7771, which had introduced a new kubelet_cmd_flags field to the KubeletConfig protobuf message. The revert removes this field and restores the codebase to use only the original kubelet_flags map-based approach.
Changes:
- Removed the
kubelet_cmd_flagsstring field from theKubeletConfigprotobuf message - Updated generated protobuf Go code to reflect the field removal
- Simplified the
getKubeletFlagshelper function to only use the map-basedkubelet_flags - Updated tests to use
KubeletFlagsmap instead of the now-removedKubeletCmdFlagsstring field - Removed unused imports from test files
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| aks-node-controller/proto/aksnodeconfig/v1/kubelet_config.proto | Removed kubelet_cmd_flags field (field 9) from KubeletConfig message |
| aks-node-controller/pkg/gen/aksnodeconfig/v1/kubelet_config.pb.go | Auto-generated code updated to remove KubeletCmdFlags field and getter method |
| aks-node-controller/proto/README.md | Documentation updated to remove references to kubelet_cmd_flags |
| aks-node-controller/parser/parser_test.go | Test updated to use KubeletFlags map instead of KubeletCmdFlags string; removed unused imports |
| aks-node-controller/parser/helper_test.go | Test simplified to use inline map definition; removed unused imports and variables |
| aks-node-controller/parser/helper.go | Simplified getKubeletFlags function to only handle map-based flags |
| aks-node-controller/Makefile | Unrelated changes to platform specifications and branch reference |
…elet_fla…" This reverts commit 748a134.
fcadf20 to
7f8a313
Compare
timmy-wright
approved these changes
Feb 4, 2026
mxj220
pushed a commit
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #7771