fix(e2e): ensure slot retrieval does not fail in ValidateNetworkInterfaceConfig#7792
Merged
fix(e2e): ensure slot retrieval does not fail in ValidateNetworkInterfaceConfig#7792
Conversation
mugeshsp
requested review from
AbelHu,
Devinwong,
awesomenix,
cameronmeissner,
djsly,
ganeshkumarashok,
juan-lee,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bash script failure in the ValidateNetworkInterfaceConfig e2e test validator when VMs don't have PCI network devices with slot names matching the enP* pattern.
Changes:
- Added
|| trueto the udevadm/awk pipeline to prevent script failure when no network interface slot is found
djsly
approved these changes
Feb 5, 2026
mxj220
pushed a commit
that referenced
this pull request
Feb 5, 2026
mxj220
pushed a commit
that referenced
this pull request
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix a bash script failure in the ValidateNetworkInterfaceConfig e2e test validator when no network interfaces match the enP* slot pattern.
The issue occurred when running with
set -euo pipefailand the awk command in the udevadm pipeline returned a non-zero exit code (no match found). This caused the entire script to exit with code 1, even though this is an expected scenario when VMs don't have PCI network devices with enP* slot names.Fixes #
|| trueto the udevadm/awk pipeline to ensure the command always succeeds