fix: deduplicate RPM selection in installRPMPackageFromFile for Azure Linux

[awesomenix]

Problem

On Azure Linux V3 nodes, when multiple RPM release versions of the same package coexist in the download cache (e.g. kubectl-1.34.3-1.azl3.x86_64.rpm and kubectl-1.34.3-2.azl3.x86_64.rpm), both files were passed to dnf install, causing "conflicting requests" errors because both RPMs provide the same package at the same version.

The root cause is that find ... -print -quit returns the first match arbitrarily, and the dependency loop later picks up the second match, resulting in both being passed to dnf_install.

Fix

• sort -V | tail -n 1 instead of -print -quit: deterministically selects the latest release version when multiple RPMs match
• rm -f before download fallback: cleans up stale RPMs before downloading a new version, preventing accumulation of conflicting release versions

Testing

Regenerated snapshot testdata via make generate-testdata — all Mariner/AzureLinux CustomData snapshots updated.

[Copilot]

Pull request overview

This PR aims to prevent Azure Linux v3/Mariner RPM install failures caused by multiple cached release variants of the same package being passed to dnf install (triggering “conflicting requests”), by making cached RPM selection deterministic and cleaning up stale cached RPMs on download fallback.

Changes:

• Update installRPMPackageFromFile RPM selection to choose the “latest” matching RPM via sort -V | tail -n 1.
• Remove stale ${packageName}-${desiredVersion}*.rpm files before downloading a fallback RPM version.
• Regenerate pkg/agent/testdata/*/CustomData snapshot outputs.

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
parts/linux/cloud-init/artifacts/mariner/cse_install_mariner.sh	Adjust RPM selection logic and cleanup behavior in installRPMPackageFromFile.
pkg/agent/testdata/Marinerv2+DisableUnattendedUpgrades=true/CustomData	Regenerated CustomData snapshot.
pkg/agent/testdata/Marinerv2+DisableUnattendedUpgrades=false/CustomData	Regenerated CustomData snapshot.
pkg/agent/testdata/MarinerV2+Kata/CustomData	Regenerated CustomData snapshot.
pkg/agent/testdata/MarinerV2+CustomCloud/CustomData	Regenerated CustomData snapshot.
pkg/agent/testdata/MarinerV2+CustomCloud+USSec/CustomData	Regenerated CustomData snapshot.
pkg/agent/testdata/MarinerV2+CustomCloud+USNat/CustomData	Regenerated CustomData snapshot.
pkg/agent/testdata/AzureLinuxv2+DisableUnattendedUpgrades=true/CustomData	Regenerated CustomData snapshot.
pkg/agent/testdata/AzureLinuxv2+DisableUnattendedUpgrades=false/CustomData	Regenerated CustomData snapshot.
pkg/agent/testdata/AzureLinuxV3+Kata/CustomData	Regenerated CustomData snapshot.
pkg/agent/testdata/AzureLinuxV2+Kata/CustomData	Regenerated CustomData snapshot.

Comments suppressed due to low confidence (1)

parts/linux/cloud-init/artifacts/mariner/cse_install_mariner.sh:449

• rpmFile selection now deterministically picks the latest matching RPM, but the later dependency-collection loop still appends other cached RPMs that match ${packageName}-${desiredVersion}-*.rpm (including older release variants). If both kubectl-<ver>-1...rpm and kubectl-<ver>-2...rpm exist, rpmArgs will still contain both and dnf_install can still hit "conflicting requests". Consider filtering cached RPMs so only the chosen rpmFile is included for the main package (or proactively deleting older ${rpmPattern}*.rpm matches before building rpmArgs).

    rpmFile=$(find "${downloadDir}" -maxdepth 1 -type f -name "${rpmPattern}*.rpm" 2>/dev/null | sort -V | tail -n 1) || rpmFile=""
    if [ -z "${rpmFile}" ]; then
        if fallbackToKubeBinaryInstall "${packageName}" "${desiredVersion}"; then
            echo "Successfully installed ${packageName} version ${desiredVersion} from binary fallback"
            rm -rf "${downloadDir}"

[Copilot]

rm -f "${downloadDir}"/${rpmPattern}*.rpm leaves ${rpmPattern} unquoted, which can trigger ShellCheck warnings (word-splitting) and is also less safe if filenames begin with -. Prefer quoting the variable portion and using -- so only the glob expands (and options can’t be parsed from filenames).

Suggested change

	rm -f "${downloadDir}"/${rpmPattern}*.rpm
	rm -f -- "${downloadDir}/${rpmPattern}"*.rpm

[Copilot]

Pull request overview

Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 18 out of 18 changed files in this pull request and generated 1 comment.