Merged
Conversation
awesomenix
requested review from
AbelHu,
Devinwong,
SriHarsha001,
calvin197,
cameronmeissner,
djsly,
ganeshkumarashok,
junjiezhang1997,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Ubuntu CSE helper used for installing locally-staged .deb artifacts so kubelet/kubectl installation can use cached packages directly (reducing unnecessary apt repository interaction and lock contention during provisioning).
Changes:
- Switch
installDebPackageFromFilefast path fromapt-get install <local.deb>todpkg -i <local.deb>. - Preserve the existing
apt-get -f installfallback behavior for dependency repair ifdpkgfails. - Improve variable scoping/quoting for the
.debfile path.
awesomenix
force-pushed
the
nishp/regression/aptmark
branch
from
a644c9c to
7bb4eb8
Compare
Ubuntu CSE was staging kubelet and kubectl debs under /opt/.../downloads, but installDebPackageFromFile still used apt-get install on the local deb path. In practice apt continued consulting PMC, refetched the packages, and overlapped with the background apt-mark walinuxagent hold flow, which inflated the installKubeletKubectlFromPkg latency in Ubuntu 22.04. Switch the fast path to a single noninteractive dpkg --force-confdef --force-confold -i of the staged deb so the hotfix uses the cached local artifact directly. Keep the existing apt-get -f install fallback unchanged so dependency repair behavior stays the same if dpkg fails. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
awesomenix
force-pushed
the
nishp/regression/aptmark
branch
from
7bb4eb8 to
7ed7c69
Compare
djsly
approved these changes
Apr 12, 2026
timmy-wright
pushed a commit
that referenced
this pull request
Apr 13, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
fseldow
pushed a commit
that referenced
this pull request
Apr 21, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ubuntu CSE was staging kubelet and kubectl debs under /opt/.../downloads, but installDebPackageFromFile still used apt-get install on the local deb path. In practice apt continued consulting PMC, refetched the packages, and overlapped with the background apt-mark walinuxagent hold flow, which inflated the installKubeletKubectlFromPkg latency in Ubuntu 22.04.
Switch the fast path to a single noninteractive
dpkg --force-confdef --force-confold -iof the staged deb so the hotfix uses the cached local artifact directly. Keep the existing apt-get -f install fallback unchanged so dependency repair behavior stays the same if dpkg fails.