disable minor update for all packages by default#8310
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates Renovate configuration to prevent minor updates across the repo by default, and adjusts RPM datasource handling.
Changes:
- Broadens the “disable minor updates” rule from an explicit package allowlist to all packages.
- Restricts the RPM rule to apply only to patch updates.
| "packageRules": [ | ||
| { | ||
| "matchPackageNames": [ | ||
| "*/kubernetes/autoscaler/addon-resizer", | ||
| "*/kubernetes/autoscaler/cluster-proportional-autoscaler", | ||
| "*/kubernetes/coredns", | ||
| "oss/v2/kubernetes/pause", | ||
| "containernetworking/azure-cni", | ||
| "containernetworking/azure-cns", | ||
| "containernetworking/azure-ipam", | ||
| "containernetworking/cilium/cilium", | ||
| "containernetworking/cilium/cilium-distroless-init", | ||
| "containernetworking/cilium/cilium-distroless", | ||
| "oss/kubernetes/apiserver-network-proxy/agent", | ||
| "oss/kubernetes-csi/secrets-store/driver", | ||
| "oss/azure/secrets-store/provider-azure", | ||
| "azuremonitor/containerinsights/ciprod", | ||
| "azuremonitor/containerinsights/ciprod/prometheus-collector/images", | ||
| "oss/kubernetes/azure-cloud-node-manager", | ||
| "oss/v2/kubernetes/azure-cloud-node-manager", | ||
| "aks/ip-masq-agent-v2", | ||
| "oss/v2/azure/ip-masq-agent-v2", | ||
| "oss/kubernetes-csi/azuredisk-csi", | ||
| "oss/v2/kubernetes-csi/azuredisk-csi", | ||
| "oss/kubernetes-csi/azurefile-csi", | ||
| "oss/v2/kubernetes-csi/azurefile-csi", | ||
| "oss/kubernetes-csi/blob-csi", | ||
| "oss/kubernetes-csi/livenessprobe", | ||
| "oss/kubernetes-csi/csi-node-driver-registrar", | ||
| "oss/v2/open-policy-agent/gatekeeper", | ||
| "azure-policy/policy-kubernetes-addon-prod", | ||
| "azure-policy/policy-kubernetes-webhook", | ||
| "oss/kubernetes/kube-proxy", | ||
| "oss/v2/kubernetes/kube-proxy", | ||
| "oss/binaries/kubernetes/kubernetes-node", | ||
| "oss/binaries/kubernetes/azure-acr-credential-provider", | ||
| "containernetworking/azure-npm", | ||
| "azure-acr-credential-provider" | ||
| ], | ||
| "matchUpdateTypes": [ | ||
| "minor" | ||
| ], |
There was a problem hiding this comment.
The PR description says this is done 'using wildcards', but the implementation achieves the global behavior by removing matchPackageNames entirely (so the rule matches everything). Either update the PR description to reflect the actual mechanism, or make the config intent explicit (e.g., add an explicit match-all pattern) so future readers don’t interpret the missing matcher as accidental.
| "matchUpdateTypes": [ | ||
| "patch" | ||
| ], |
There was a problem hiding this comment.
Adding matchUpdateTypes: [\"patch\"] means the custom versioning regex will only apply to patch updates for RPM. If Renovate needs this regex to correctly parse/compare RPM versions, then minor/major RPM updates (or pins/digests, depending on repo settings) may be evaluated under default versioning rules, which can lead to incorrect update behavior. Consider removing matchUpdateTypes here, or duplicating the rule (same versioning) for the other update types you still want Renovate to evaluate consistently.
| "matchUpdateTypes": [ | |
| "patch" | |
| ], |
PR Title Lint Failed ❌Current Title: Your PR title doesn't follow the expected format. Please update your PR title to follow one of these patterns: Conventional Commits Format:
Guidelines:
Examples:
Please update your PR title and the lint check will run again automatically. |
|
@Devinwong not sure this makes sense, I would revert and revisit how we want to do it. |
What this PR does / why we need it:
Disable minor update for all packages by default (using wildcards). We unintentionally enabled some packages earlier.
Which issue(s) this PR fixes:
Fixes #